From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B592AC433DB for ; Tue, 12 Jan 2021 13:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 606AE22B30 for ; Tue, 12 Jan 2021 13:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732459AbhALNr6 convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2021 08:47:58 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:28121 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731385AbhALNr5 (ORCPT ); Tue, 12 Jan 2021 08:47:57 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-244-i8hIuy4hNtCF7lb5ZonnQQ-1; Tue, 12 Jan 2021 13:46:18 +0000 X-MC-Unique: i8hIuy4hNtCF7lb5ZonnQQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 12 Jan 2021 13:46:16 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 12 Jan 2021 13:46:16 +0000 From: David Laight To: 'Florian Weimer' , Lukas Wunner CC: Linus Torvalds , Will Deacon , Peter Zijlstra , Arnd Bergmann , Russell King - ARM Linux admin , "linux-toolchains@vger.kernel.org" , "Mark Rutland" , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Subject: RE: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Topic: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Index: AQHW6OeTm0FM5rtghkqQZIJPrgzUmKokAGNg Date: Tue, 12 Jan 2021 13:46:16 +0000 Message-ID: References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> <20210112132049.GA26096@wunner.de> <877doii8n2.fsf@oldenburg2.str.redhat.com> In-Reply-To: <877doii8n2.fsf@oldenburg2.str.redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Weimer > Sent: 12 January 2021 13:32 > > * Lukas Wunner: > > > On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: > >> I appreciate Arnd pointing out "--std=gnu11", though. What are the > >> actual relevant language improvements? > >> > >> Variable declarations in for-loops is the only one I can think of. I > >> think that would clean up some code (and some macros), but might not > >> be compelling on its own. > > > > Anonymous structs/unions. I used to have a use case for that in > > struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel > > refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. > > Aren't those a GNU extension supported since GCC 3.0? They are certainly pretty old. The 15 year old gcc we use for release builds (so binaries work on old distributions) supports them. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)