From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755982AbcEXRfG (ORCPT ); Tue, 24 May 2016 13:35:06 -0400 Received: from piie.net ([80.82.223.85]:43252 "EHLO piie.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbcEXRfE convert rfc822-to-8bit (ORCPT ); Tue, 24 May 2016 13:35:04 -0400 Mime-Version: 1.0 Date: Tue, 24 May 2016 17:34:58 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-ID: X-Mailer: RainLoop/1.10.0.107 From: "Peter Feuerer" Subject: Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary To: "Javi Merino" , "Caesar Wang" Cc: edubezval@gmail.com, "Heiko Stuebner" , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, "Sascha Hauer" , "Zhang Rui" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20160524130610.GC8979@e104805> References: <20160524130610.GC8979@e104805> <1462268013-14992-1-git-send-email-wxt@rock-chips.com> <1462268013-14992-5-git-send-email-wxt@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb: > Ccing Peter Feuerer, author of the bang bang governor. > > On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > >> From: Sascha Hauer >> >> With interrupt driven thermal zones we pass the lower and upper >> temperature on which shall be acted, so in the governor we have to act on >> the exact lower temperature to be consistent. Otherwise an interrupt maybe >> generated on the exact lower temperature, but the bang bang governor does >> not react since The polling driven zones have to be one step cooler before >> the governor reacts. >> >> Signed-off-by: Sascha Hauer >> Signed-off-by: Caesar Wang >> Cc: Zhang Rui >> Cc: Eduardo Valentin >> Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer >> >> --- >> >> Changes in v2: >> - Update the commit for patch[v2 4/5]. >> >> drivers/thermal/gov_bang_bang.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >> index 70836c5..9d1dfea 100644 >> --- a/drivers/thermal/gov_bang_bang.c >> +++ b/drivers/thermal/gov_bang_bang.c >> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >> if (instance->target == 0 && tz->temperature >= trip_temp) >> instance->target = 1; >> else if (instance->target == 1 && >> - tz->temperature < trip_temp - trip_hyst) >> + tz->temperature <= trip_temp - trip_hyst) >> instance->target = 0; >> >> dev_dbg(&instance->cdev->device, "target=%d\n", >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html