From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A49C433F5 for ; Fri, 3 Sep 2021 19:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBE9660FC0 for ; Fri, 3 Sep 2021 19:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350050AbhICTyr (ORCPT ); Fri, 3 Sep 2021 15:54:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234588AbhICTyq (ORCPT ); Fri, 3 Sep 2021 15:54:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9263C061575 for ; Fri, 3 Sep 2021 12:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=s9zCYO7ivn9bU2YwE2qebeEwOr+P6P9//Z0Xkx78JGc=; b=O85JfQg3VssOC2PATbgi4EahTA /v9SSF1wiD5OxR9p7UNlHHzlad+YmtNR4Px0IhcKiohXUQ7OGzrVNrXHGG+v5HLJBvL6/B8qlTPG0 D5AvHQDfsT7jaXZe0fx7brjYHoN2nwVFE5B8hh+sMO2qvjJfKCpvhsqoDOsgEVPBWQpMY8IsnuoIj tniApLqBuuKQ/pcaNtbcEvVW2fPuVO4ljrzznoIZxmGFeJX8JGdtT5ioa82Q3coEk9Aw1uZQGuqgB 51E+qJeRFweWU46M3AKBkcECEStYef5xcB1LYoiSIeud8a4nQ0cEV+Il0Vmv7Ztxw1ywa+USz48XQ FmMlhjAQ==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMFFo-00CpGx-Vu; Fri, 03 Sep 2021 19:53:37 +0000 Subject: Re: [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA To: Geert Uytterhoeven Cc: Codrin.Ciubotariu@microchip.com, Linux Kernel Mailing List , ALSA Development Mailing List , Liam Girdwood , Mark Brown , mirq-linux@rere.qmqm.pl, Alexandre Belloni References: <20210707214752.3831-1-rdunlap@infradead.org> <49495ab9-5039-f332-2895-1a79c034f58d@infradead.org> From: Randy Dunlap Message-ID: Date: Fri, 3 Sep 2021 12:53:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/21 9:44 AM, Geert Uytterhoeven wrote: > Hi Randy, > > On Thu, Jul 8, 2021 at 6:51 PM Randy Dunlap wrote: >> On 7/8/21 1:19 AM, Codrin.Ciubotariu@microchip.com wrote: >>> On 08.07.2021 00:47, Randy Dunlap wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>> >>>> On a config (such as arch/sh/) which does not set HAS_DMA when MMU >>>> is not set, several ATMEL ASoC drivers select symbols that cause >>>> kconfig warnings. There is one "depends on HAS_DMA" which is no longer >>>> needed. Dropping it eliminates the kconfig warnings and still builds >>>> with no problems reported. >>>> >>>> Fix the following kconfig warnings: >>>> >>>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC >>>> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] >>>> Selected by [m]: >>>> - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] >>>> - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] >>>> >>>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC >>>> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] >>>> Selected by [m]: >>>> - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] >>>> >>>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC >>>> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] >>>> Selected by [m]: >>>> - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] >>>> >>>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA >>>> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] >>>> Selected by [m]: >>>> - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m] >>>> - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] >>>> >>>> Fixes: 3951e4aae2ce ("ASoC: atmel-pcm: dma support based on pcm dmaengine") >>>> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig") >>>> Fixes: 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") >>> >>> I am not sure about these fixes tags. As Alexandre mentioned, it looks >>> like the reason for HAS_DMA in the first place was the COMPILE_TEST with >>> m32r arch. I dig a bit, and, if any, I think we should use: >>> Fixes: eb17726b00b3 ("m32r: add simple dma") >>> since this commit adds dummy DMA support for m32r and seems to fix the >>> HAS_DMA dependency. >> >> Ah, I forgot to update the Fixes: tag(s). >> >> I won't disagree with your Fixes: suggestion (good digging) but >> I would probably have used 8d7d11005e930: >> ASoC: atmel: fix build failure >> which is the commit that added "depends on HAS_DMA". > > M32r was not the only platform NO_DMA, so I guess the build would > have failed for the others, too (e.g. Sun-3). > > So the real fix was probably commit f29ab49b5388b2f8 ("dma-mapping: > Convert NO_DMA get_dma_ops() into a real dummy"), or one of the > related commits adding dummies to subsystems. Hi Geert, Does this mean that some other actions are needed here? E.g. revert + a different kind of fix? thanks. -- ~Randy