From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org, ak@linux.intel.com,
eranian@google.com, stable@vger.kernel.org
Subject: Re: [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX
Date: Fri, 21 Sep 2018 10:37:22 -0400 [thread overview]
Message-ID: <a95a3f49-d051-fed8-420b-94f437bc9609@linux.intel.com> (raw)
In-Reply-To: <20180921141437.GE24124@hirez.programming.kicks-ass.net>
On 9/21/2018 10:14 AM, Peter Zijlstra wrote:
> On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
>> these counters may causes system crash on some machines.
>>
>> The PCI BDF addresses of M3UPI in current code are incorrect.
>> The correct addresses should be
>> D18:F1 0x204D
>> D18:F2 0x204E
>> D18:F5 0x204D
>
> Should this have a Fixes: tag?
>
Yes, sorry for missing it.
Here it is.
Fixes: cd34cd97b7b4 ("perf/x86/intel/uncore: Add Skylake server uncore
support")
Thanks,
Kan
next prev parent reply other threads:[~2018-09-21 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 14:07 [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX kan.liang
2018-09-21 14:14 ` Peter Zijlstra
2018-09-21 14:37 ` Liang, Kan [this message]
2018-10-02 10:02 ` [tip:perf/core] " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a95a3f49-d051-fed8-420b-94f437bc9609@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).