From: Florian Fainelli <f.fainelli@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>
Cc: SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete #address-cells from ssp3
Date: Mon, 9 Nov 2020 19:19:30 -0800 [thread overview]
Message-ID: <a98683e3-c666-a308-9c67-b898134c13fe@gmail.com> (raw)
In-Reply-To: <20200718205019.184927-3-lkundrak@v3.sk>
On 7/18/2020 1:50 PM, Lubomir Rintel wrote:
> On the XO-1.75, this node represents a bus interface that operates in slave
> mode and thus is only able to accommodate a single subnode; no address
> cells are necessary.
>
> The Documentation/devicetree/bindings/spi/spi-controller.yaml binding
> prefers that we drop the property instead of setting it to zero.
>
> This fixes a DT validation error:
>
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
> { ... } is valid under each of {'required': ['spi-slave']},
> {'required': ['#address-cells']}
>
> We also need to drop #size-cells:
>
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
> '#address-cells' is a dependency of '#size-cells'
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
This patch causes the following warning to be issued when validating the
mmp2 DTS files against specific bindings:
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus
also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus
also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: Warning (spi_bus_reg):
Failed prerequisite 'spi_bus_bridge'
Is there a fix that we can apply to silence this warning? Thanks!
--
Florian
next prev parent reply other threads:[~2020-11-10 3:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 20:50 [PATCH v2 00/13] MMP DTS updates for 5.9 Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 01/13] ARM: dts: mmp2-olpc-xo-1-75: Fix camera I2C node validation Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete #address-cells from ssp3 Lubomir Rintel
2020-11-10 3:19 ` Florian Fainelli [this message]
2020-07-18 20:50 ` [PATCH v2 03/13] ARM: dts: mmp2: Add #power-domain-cells to /clocks Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 04/13] ARM: dts: mmp2: Extend the MPMU reg range Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 05/13] ARM: dts: mmp2: Add Audio SRAM Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 06/13] ARM: dts: mmp2: Add DMA nodes Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 07/13] ARM: dts: mmp2: Add Audio Clock controller Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 08/13] ARM: dts: mmp2: Add SSPA nodes Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 09/13] ARM: dts: mmp2-olpc-xo-1-75: Enable audio support Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 10/13] ARM: dts: mmp2: Add the GPU Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 11/13] ARM: dts: mmp2-olpc-xo-1-75: Enable " Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 12/13] ARM: dts: mmp3: Add " Lubomir Rintel
2020-07-18 20:50 ` [PATCH v2 13/13] ARM: dts: mmp3-dell-ariel: Enable " Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a98683e3-c666-a308-9c67-b898134c13fe@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).