From: Faiz Abbas <faiz_abbas@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-can@vger.kernel.org>,
<broonie@kernel.org>, <lgirdwood@gmail.com>,
<catalin.marinas@arm.com>, <mark.rutland@arm.com>,
<mkl@pengutronix.de>, <wg@grandegger.com>,
<sriram.dash@samsung.com>, <dmurphy@ti.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: m_can: Add Documentation for transceiver regulator
Date: Fri, 21 Feb 2020 14:01:46 +0530 [thread overview]
Message-ID: <a987bcd7-ca1c-dfda-72f3-cd2004a87ea5@ti.com> (raw)
In-Reply-To: <20200219203529.GA21085@bogus>
Hi Rob,
On 20/02/20 2:05 am, Rob Herring wrote:
> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>> Some CAN transceivers have a standby line that needs to be asserted
>> before they can be used. Model this GPIO lines as an optional
>> fixed-regulator node. Document bindings for the same.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>> Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>
> This has moved to DT schema in my tree, so please adjust it and resend.
Ok.
>
>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>> index ed614383af9c..f17e2a5207dc 100644
>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>> @@ -48,6 +48,9 @@ Optional Subnode:
>> that can be used for CAN/CAN-FD modes. See
>> Documentation/devicetree/bindings/net/can/can-transceiver.txt
>> for details.
>> +
>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>
> The supply for a transceiver should go in the transceiver node.
>
Marc, while I have you here, do you agree with this?
Thanks,
Faiz
next prev parent reply other threads:[~2020-02-21 8:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 14:28 [PATCH v2 0/3] Add Support for MCAN in AM654x-idk Faiz Abbas
2020-02-17 14:28 ` [PATCH v2 1/3] dt-bindings: m_can: Add Documentation for transceiver regulator Faiz Abbas
2020-02-19 20:35 ` Rob Herring
2020-02-21 8:31 ` Faiz Abbas [this message]
2020-02-21 8:31 ` Marc Kleine-Budde
2020-02-26 9:10 ` Faiz Abbas
2020-03-02 8:16 ` Faiz Abbas
2020-03-09 14:30 ` Faiz Abbas
2020-02-17 14:28 ` [PATCH v2 2/3] can: m_can: m_can_platform: Add support for enabling transceiver Faiz Abbas
2020-02-17 15:10 ` Dan Murphy
2020-02-21 7:54 ` Faiz Abbas
2020-02-21 8:09 ` Marc Kleine-Budde
2020-02-17 14:28 ` [PATCH v2 3/3] arm64: defconfig: Add Support for Bosch M_CAN controllers Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a987bcd7-ca1c-dfda-72f3-cd2004a87ea5@ti.com \
--to=faiz_abbas@ti.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).