From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>, Sandro Volery <sandro@volery.com>
Cc: linux-kernel@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH] Fixed most indent issues in tty_io.c
Date: Sat, 07 Sep 2019 12:27:16 -0700 [thread overview]
Message-ID: <a99b7481f26138ea01de0d271e9aec2a525c0aed.camel@perches.com> (raw)
In-Reply-To: <20190907174232.GA20070@kroah.com>
On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote:
> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
> >
> > > > > On 7 Sep 2019, at 19:29, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
> > > > Dear Greg,
> > > > I am pretty sure the issue was, that I did too many things at once. However, all the things I did are related to spaces / tabs, maybe that still works?
> > >
> > > <snip>
> > >
> > > For some reason you sent this only to me, which is a bit rude to
> > > everyone else on the mailing list. I'll be glad to respond if you
> > > resend it to everyone.
> >
> > I'm sorry, newbie here. I thought it'd be better to not annoy everyone with responses but learning things everyday I guess :)
>
> No problem, but you should also line-wrap your emails :)
>
> > I am pretty sure the issue with my patch was that there was too many changes, however all of them were spaces and tabs related, so I think this could be fine?
>
> As the bot said, break it out into "one patch per logical change", and
> "fix all whitespace issues" is not "one logical change".
As long as git diff -w shows no difference and a compiled
object comparison before and after the change shows no
difference, I think it's fine.
In fact, it avoid multiple commits where the only changes
are whitespace.
next prev parent reply other threads:[~2019-09-07 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190907172944.GB18166@kroah.com>
2019-09-07 17:35 ` [PATCH] Fixed most indent issues in tty_io.c Sandro Volery
2019-09-07 17:42 ` Greg KH
2019-09-07 17:49 ` Sandro Volery
2019-09-07 18:02 ` Greg KH
2019-09-07 18:05 ` Sandro Volery LKML
2019-09-07 19:27 ` Joe Perches [this message]
2019-09-07 19:51 ` Sandro Volery
2019-09-07 20:01 ` Joe Perches
2019-09-08 23:32 Sandro Volery
-- strict thread matches above, loose matches on Subject: below --
2019-09-07 9:09 volery
2019-09-07 17:07 ` Greg KH
2019-09-07 20:04 ` Joe Perches
2019-09-07 20:30 ` Sandro Volery
2019-09-08 20:59 ` Theodore Y. Ts'o
2019-09-09 8:17 ` Sandro Volery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99b7481f26138ea01de0d271e9aec2a525c0aed.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandro@volery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).