From: Shannon Nelson <snelson@pensando.io>
To: YueHaibing <yuehaibing@huawei.com>,
Pensando Drivers <drivers@pensando.io>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'
Date: Mon, 28 Oct 2019 09:30:21 -0700 [thread overview]
Message-ID: <a9acbf5c-a6d7-0115-2ca9-53368ba12508@pensando.io> (raw)
In-Reply-To: <20191028120121.20743-1-yuehaibing@huawei.com>
On 10/28/19 5:01 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
> variable 'sg_desc' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index 0aeac3157160..97e79949b359 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -402,7 +402,6 @@ static void ionic_rx_fill_cb(void *arg)
>
> void ionic_rx_empty(struct ionic_queue *q)
> {
> - struct ionic_rxq_sg_desc *sg_desc;
> struct ionic_desc_info *cur;
> struct ionic_rxq_desc *desc;
> unsigned int i;
> @@ -412,7 +411,6 @@ void ionic_rx_empty(struct ionic_queue *q)
> desc->addr = 0;
> desc->len = 0;
>
> - sg_desc = cur->sg_desc;
> for (i = 0; i < cur->npages; i++) {
> if (likely(cur->pages[i].page)) {
> ionic_rx_page_free(q, cur->pages[i].page,
>
>
>
next prev parent reply other threads:[~2019-10-28 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 12:01 [PATCH net-next] ionic: Remove set but not used variable 'sg_desc' YueHaibing
2019-10-28 16:30 ` Shannon Nelson [this message]
2019-10-29 23:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9acbf5c-a6d7-0115-2ca9-53368ba12508@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).