From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937645AbdAHVnF (ORCPT ); Sun, 8 Jan 2017 16:43:05 -0500 Received: from mout.web.de ([212.227.15.4]:62110 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754753AbdAHVmq (ORCPT ); Sun, 8 Jan 2017 16:42:46 -0500 Subject: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() To: linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Shawn Lin , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sun, 8 Jan 2017 22:42:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9D/KPMA1cmYvk+ffV/RIgbYlCGDWF8qqEZdFUeUqfq34UuapfnD MUyTNiBwSXzbHwqG+4BVEuI4QjmE4pHvdDIQo1AXILKrcc26FNfNalTc2Gp5Zojsdows0HF sUVrYsYdhHlyepqKAmRzYr+MVLvDvuRBcK2HffGbxNjYbZUpy6ibS1/1ATkktSZ9pXdKBZ/ uri8ayKaGCWFreE5VPKFg== X-UI-Out-Filterresults: notjunk:1;V01:K0:6qrYsm+k7Z0=:YQzd07Vek9KOBfbzGYxYn2 GxzQlFSi+D7Z47xPm/XCLim6BubP4pCTt1KgJ/7aFmxT2Bu5uOCSDDGEqyEM7CzkSZXBxC8vu g5jf3NjjhGLPb8krRyh2uumarbKkabmZKH2QdbIdNlYqpDbGsuMIq05B6pSbphanR3DLZrn1r L0OpnDYWv3r3nFTDC8aByGOAMAmShz9VuxDcqpUL+Gw5WhXnrywtwycChHhY125fpaNEFJ5op NHc70k3pUWR/u4AL63+hzTr9tB0M4j379gzqOLWtRwjVW8UjJp/PNCaJnwrVuJAcyjb8VP98a 9lkyDz3YF6mie5lrqNBYJwzEytm228N5+SaJ4Vlq2PNQ8FbsBG/MSxBG7nKm55a4axNxQYqPX IZ6H7KRkBdqrdf7HpjwdSuJIyPV7LJXdwKHVw3V7LLeAl3D2qnOGBzQNsbvALOFxFgpryPjRS RO+U/tyLXHOYfpjfjKsTgSugi8fFTCJRemBhdnTVZ/y8UHoaH6MJPEQCpm7fHjnoMy3h1I413 sbxA1jYPKCZfHRPANdYW5tLkKh+JMgObIeS3IHLs5PH5SBEQbmObfi1XSR52fzQW0dpkPQ70e G6NYJ77uZkG7Pavr77cK+VJZBZRi+2b+S9w4LOeBuznMTJIXZe1Fvs8Lh2/xysjVrRzobKavZ scRxdlweNHsapnE2p3Q1Xjv5TxKTsPYxeh0Roa/lNx7Lw6+L0dFMREE99xXAa2AZLCYZ3vPuz dBDZT0AMxzKAOIgVM/I1dYBZLXqDbjj86oY8AZydIzOZIAmEbynDbJ8dzjZ8pZhC/AfU3eZYL 12fxpq6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 8 Jan 2017 18:44:26 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mmc/core/mmc_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c index 3ab6e52d106c..e85ef503d7ce 100644 --- a/drivers/mmc/core/mmc_test.c +++ b/drivers/mmc/core/mmc_test.c @@ -1579,7 +1579,7 @@ static int mmc_test_area_init(struct mmc_test_card *test, int erase, int fill) if (!t->mem) return -ENOMEM; - t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL); + t->sg = kmalloc_array(t->max_segs, sizeof(*t->sg), GFP_KERNEL); if (!t->sg) { ret = -ENOMEM; goto out_free; -- 2.11.0