From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D90C00454 for ; Thu, 12 Dec 2019 14:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07E0E214AF for ; Thu, 12 Dec 2019 14:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbfLLOKy (ORCPT ); Thu, 12 Dec 2019 09:10:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:48200 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729392AbfLLOKx (ORCPT ); Thu, 12 Dec 2019 09:10:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 90F17ACE1; Thu, 12 Dec 2019 14:10:51 +0000 (UTC) Subject: Re: [RFC 19/25] leds: tm1628: Add 7-segment display support To: Geert Uytterhoeven Cc: linux-realtek-soc@lists.infradead.org, linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , Dan Murphy , Linux ARM , Linux Kernel Mailing List References: <20191212033952.5967-1-afaerber@suse.de> <20191212033952.5967-20-afaerber@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Thu, 12 Dec 2019 15:10:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Am 12.12.19 um 09:33 schrieb Geert Uytterhoeven: > On Thu, Dec 12, 2019 at 4:42 AM Andreas Färber wrote: >> Detect DT child nodes covering more than one LED component and implement >> a text to 7-segment display mapping. >> >> Signed-off-by: Andreas Färber > >> --- a/drivers/leds/leds-tm1628.c >> +++ b/drivers/leds/leds-tm1628.c > >> +static const struct tm1628_ssd_char tm1628_char_ssd_map[] = { >> + { '0', SSD_TOP | SSD_TOP_LEFT | SSD_TOP_RIGHT | >> + SSD_BOTTOM_LEFT | SSD_BOTTOM_RIGHT | SSD_BOTTOM }, > > Please use include/uapi/linux/map_to_7segment.h > Yes, it is well hidden ;-). Many thanks for that pointer! Even matches the segment/bit order of my datasheets/defines. The small t may be different (T?), and I don't see it mapping combined characters (patch 22/25). The recommended sysfs map_7seg attribute may help deal with that, but seems terribly unhandy for my busybox initrd. Hope you also read the cover letter, where not finding this and many other issues were discussed. I was expecting some .c file in either drivers/leds or auxdisplay - input is indeed unexpected for output. Still wondering whether we can somehow describe those "VFD" displays in a more reusable way, like we do for MIPI DSI panels. Cheers, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)