linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]gen_initramfs_list.sh
@ 2019-12-04 15:48 Jory A. Pratt
  2019-12-04 16:17 ` [PATCH]gen_initramfs_list.sh Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Jory A. Pratt @ 2019-12-04 15:48 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

As stated in patch the script is a non posix bash script and should use
bash instead of config_shell




[-- Attachment #2: 0001-gen_initramfs_list.sh-is-a-bash-script-that-isn-t-po.patch --]
[-- Type: text/x-patch, Size: 1015 bytes --]

From 6a7ef73882393e23e966e7b53e7b03397ad18e63 Mon Sep 17 00:00:00 2001
From: Jory Pratt <anarchy@gentoo.org>
Date: Wed, 4 Dec 2019 09:30:17 -0600
Subject: [PATCH] gen_initramfs_list.sh is a bash script that isn't posix
 compliant.

This ensures we call bash instead of sh which could be dash or any other
shell that is not compatible with the script.

Signed-off-by: Jory Pratt <anarchy@gentoo.org>
---
 usr/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr/Makefile b/usr/Makefile
index e6f7cb2f81db..27987f18eb20 100644
--- a/usr/Makefile
+++ b/usr/Makefile
@@ -27,7 +27,7 @@ $(obj)/initramfs_data.o: $(obj)/$(datafile_y) FORCE
 # Generate the initramfs cpio archive
 
 hostprogs-y := gen_init_cpio
-initramfs   := $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs_list.sh
+initramfs   := $(BASH) $(srctree)/$(src)/gen_initramfs_list.sh
 ramfs-input := $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \
 			$(shell echo $(CONFIG_INITRAMFS_SOURCE)),-d)
 ramfs-args  := \
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH]gen_initramfs_list.sh
  2019-12-04 15:48 [PATCH]gen_initramfs_list.sh Jory A. Pratt
@ 2019-12-04 16:17 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2019-12-04 16:17 UTC (permalink / raw)
  To: Jory A. Pratt, linux-kernel

On 12/4/19 7:48 AM, Jory A. Pratt wrote:
> As stated in patch the script is a non posix bash script and should use
> bash instead of config_shell

Hi,
You will need to send this to some maintainer to merge it.

Maintainers don't usually scan LKML to pick up patches.

thanks.
-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-04 16:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 15:48 [PATCH]gen_initramfs_list.sh Jory A. Pratt
2019-12-04 16:17 ` [PATCH]gen_initramfs_list.sh Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).