From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF739C64E7C for ; Mon, 30 Nov 2020 03:09:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8387520757 for ; Mon, 30 Nov 2020 03:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JXVS5jGn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726805AbgK3DJl (ORCPT ); Sun, 29 Nov 2020 22:09:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40584 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbgK3DJl (ORCPT ); Sun, 29 Nov 2020 22:09:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606705695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=clkfvuFNq2hdJY744R66AkCZTfv6bN3GZv0TvqZ3EpY=; b=JXVS5jGnqy+3VY/Nh/fxV9W270xQezU22KtGB68kk9Bl/73weVWFBhq0NtB4KJTFRwRL6Z wXwljNF25LLT58mOVTQJSvSiEoR2eYJzYGChOxPbLEyU8KReEUgZr9WZkrK2e0XGZD44H7 hqRW2ecsK3gpeoArlsfh8MkZgQCdCGw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-6ZjAUzukNdCXz1y0d7gwmg-1; Sun, 29 Nov 2020 22:08:12 -0500 X-MC-Unique: 6ZjAUzukNdCXz1y0d7gwmg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 741EA1E7ED; Mon, 30 Nov 2020 03:08:11 +0000 (UTC) Received: from [10.72.13.173] (ovpn-13-173.pek2.redhat.com [10.72.13.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EC5D60C4D; Mon, 30 Nov 2020 03:07:59 +0000 (UTC) Subject: Re: [PATCH v2 05/17] vdpa_sim: rename vdpasim_config_ops variables To: Stefano Garzarella , virtualization@lists.linux-foundation.org Cc: Stefan Hajnoczi , linux-kernel@vger.kernel.org, Laurent Vivier , Max Gurtovoy , "Michael S. Tsirkin" , Eli Cohen References: <20201126144950.92850-1-sgarzare@redhat.com> <20201126144950.92850-6-sgarzare@redhat.com> From: Jason Wang Message-ID: Date: Mon, 30 Nov 2020 11:07:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201126144950.92850-6-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/26 下午10:49, Stefano Garzarella wrote: > These variables stores generic callbacks used by the vDPA simulator > core, so we can remove the 'net' word in their names. > > Co-developed-by: Max Gurtovoy > Signed-off-by: Max Gurtovoy > Signed-off-by: Stefano Garzarella > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Jason Wang > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 40664d87f303..62204e064841 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -331,8 +331,8 @@ static const struct dma_map_ops vdpasim_dma_ops = { > .free = vdpasim_free_coherent, > }; > > -static const struct vdpa_config_ops vdpasim_net_config_ops; > -static const struct vdpa_config_ops vdpasim_net_batch_config_ops; > +static const struct vdpa_config_ops vdpasim_config_ops; > +static const struct vdpa_config_ops vdpasim_batch_config_ops; > > static struct vdpasim *vdpasim_create(void) > { > @@ -342,9 +342,9 @@ static struct vdpasim *vdpasim_create(void) > int i, ret = -ENOMEM; > > if (batch_mapping) > - ops = &vdpasim_net_batch_config_ops; > + ops = &vdpasim_batch_config_ops; > else > - ops = &vdpasim_net_config_ops; > + ops = &vdpasim_config_ops; > > vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops, VDPASIM_VQ_NUM); > if (!vdpasim) > @@ -657,7 +657,7 @@ static void vdpasim_free(struct vdpa_device *vdpa) > kfree(vdpasim->vqs); > } > > -static const struct vdpa_config_ops vdpasim_net_config_ops = { > +static const struct vdpa_config_ops vdpasim_config_ops = { > .set_vq_address = vdpasim_set_vq_address, > .set_vq_num = vdpasim_set_vq_num, > .kick_vq = vdpasim_kick_vq, > @@ -684,7 +684,7 @@ static const struct vdpa_config_ops vdpasim_net_config_ops = { > .free = vdpasim_free, > }; > > -static const struct vdpa_config_ops vdpasim_net_batch_config_ops = { > +static const struct vdpa_config_ops vdpasim_batch_config_ops = { > .set_vq_address = vdpasim_set_vq_address, > .set_vq_num = vdpasim_set_vq_num, > .kick_vq = vdpasim_kick_vq,