From: Dmitry Osipenko <digetx@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Zhang Rui" <rui.zhang@intel.com>,
"Linux PM mailing list" <linux-pm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Chunyan Zhang" <zhang.chunyan@linaro.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Rajeshwari Ravindra Kamble" <rkambl@codeaurora.org>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Yangtao Li" <tiny.windzz@gmail.com>,
"Finley Xiao" <finley.xiao@rock-chips.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL] thermal for v5.14-rc1
Date: Sun, 4 Jul 2021 15:04:06 +0300 [thread overview]
Message-ID: <aa250ea4-7871-dd39-dbf6-bffa6e732919@gmail.com> (raw)
In-Reply-To: <e6ac56a5-0b7e-bfbf-7e98-8bc3f39190fd@linaro.org>
04.07.2021 12:51, Daniel Lezcano пишет:
> On 03/07/2021 21:56, Dmitry Osipenko wrote:
>> 03.07.2021 22:34, Linus Torvalds пишет:
>>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>>>> tags/thermal-v5.14-rc1
>>>
>>> This does not build for me. And I suspect it never built in linux-next either.
>>>
>>> I get
>>>
>>> ERROR: modpost: "tegra_fuse_readl"
>>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>>> ERROR: modpost: "tegra_fuse_readl"
>>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>>> make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>>> make[1]: *** Deleting file 'modules-only.symvers'
>>> make: *** [Makefile:1762: modules] Error 2
>>>
>>> and I think it's due to that commit 1f9c5936b10c
>>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
>>> quite sensibly tries to extend build coverage for the tegra thermal
>>> drivers, but that build coverage doesn't actually *work* outside the
>>> tegra world.
>>>
>>> That commit says "All Tegra thermal drivers support compile-testing",
>>> but clearly they stumble at the last hurdle.
>>>
>>> I made the decision to just unpull this, not because I couldn't fix
>>> it, but because if it was this untested, I don't want to worry about
>>> all the *other* code in there too.
>>
>> It was tested in linux-next for about two weeks and it was a known
>> problem already [1], sorry again. The compile-testing depends on the
>> patch [2] that should come with the ARM32 PR. The linux-next was okay
>> because [2] got first into -next and I forgot about it. It will be fine
>> to defer these Tegra patches till the next release if this is the
>> easiest solution.
>
> My bad, I did a wrong decision assuming the ARM32 branch would be
> already there when pulling the thermal branch.
>
> I'll remove the patches.
>
> Sorry for the inconvenience.
Daniel, please let me know if I will need to resend the thermal patches
for 5.15.
next prev parent reply other threads:[~2021-07-04 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 16:17 [GIT PULL] thermal for v5.14-rc1 Daniel Lezcano
2021-07-03 19:34 ` Linus Torvalds
2021-07-03 19:56 ` Dmitry Osipenko
2021-07-04 9:51 ` Daniel Lezcano
2021-07-04 12:04 ` Dmitry Osipenko [this message]
2021-07-04 13:19 ` Daniel Lezcano
2021-07-04 13:28 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa250ea4-7871-dd39-dbf6-bffa6e732919@gmail.com \
--to=digetx@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=ezequiel@collabora.com \
--cc=finley.xiao@rock-chips.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rkambl@codeaurora.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tiny.windzz@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).