From: "heying (H)" <heying24@huawei.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Daniel Axtens <dja@axtens.net>, <benh@kernel.crashing.org>,
<paulus@samba.org>, <npiggin@gmail.com>,
<akpm@linux-foundation.org>, <aneesh.kumar@linux.ibm.com>,
<rppt@kernel.org>, <ardb@kernel.org>, <clg@kaod.org>,
<christophe.leroy@csgroup.eu>
Cc: <johnny.chenyi@huawei.com>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings
Date: Thu, 18 Mar 2021 10:37:26 +0800 [thread overview]
Message-ID: <aa312971-cedd-38bf-ac5c-6f3d4ff2c208@huawei.com> (raw)
In-Reply-To: <877dm6ouw5.fsf@mpe.ellerman.id.au>
在 2021/3/17 19:57, Michael Ellerman 写道:
> Daniel Axtens <dja@axtens.net> writes:
>> "heying (H)" <heying24@huawei.com> writes:
>>
>>> Thank you for your reply.
>>>
>>> 在 2021/3/17 11:04, Daniel Axtens 写道:
>>>> Hi He Ying,
>>>>
>>>> Thank you for this patch.
>>>>
>>>> I'm not sure what the precise rules for Fixes are, but I wonder if this
>>>> should have:
>>>>
>>>> Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses")
>>>> Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry")
>>> Is that necessary for warning cleanups? I thought 'Fixes' tags are
>>> needed only for
>>>
>>> bugfix patches. Can someone tell me whether I am right?
>> Yeah, I'm not sure either. Hopefully mpe will let us know.
> It's not necessary to add a Fixes tag for a patch like this, but you can
> add one if you think it's important that the fix gets backported.
>
> I don't think the cleanups in this case are that important, so I
> wouldn't bother with a Fixes tag.
Okay. That's a good explanation to me. Thanks.
next prev parent reply other threads:[~2021-03-18 2:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 4:11 [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings He Ying
2021-03-16 6:57 ` Christophe Leroy
2021-03-17 3:04 ` Daniel Axtens
2021-03-17 3:37 ` heying (H)
2021-03-17 7:58 ` Daniel Axtens
2021-03-17 11:57 ` Michael Ellerman
2021-03-18 2:37 ` heying (H) [this message]
2021-03-31 1:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa312971-cedd-38bf-ac5c-6f3d4ff2c208@huawei.com \
--to=heying24@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=clg@kaod.org \
--cc=dja@axtens.net \
--cc=johnny.chenyi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).