From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Abbott Liu <liuwenliang@huawei.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
christoffer.dall@arm.com, Marc Zyngier <marc.zyngier@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Nicolas Pitre <nico@fluxnic.net>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Kees Cook <keescook@chromium.org>,
jinb.park7@gmail.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Rob Landley <rob@landley.net>,
Greg KH <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thomas Gleixner <tglx@linutronix.de>,
thgarnie@google.com, David Howells <dhowells@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andre Przywara <andre.przywara@arm.com>,
julien.thierry@arm.com, drjones@redhat.com, philip@cog.systems,
mhocko@suse.com, kirill.shutemov@linux.intel.com,
kasan-dev@googlegroups.com,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvmarm@lists.cs.columbia.edu,
Andrey Ryabinin <ryabinin.a.a@gmail.com>
Subject: Re: [PATCH v6 2/6] ARM: Disable instrumentation for some code
Date: Thu, 11 Jul 2019 09:53:51 -0700 [thread overview]
Message-ID: <aa45795c-7fa1-ebb8-5d26-cce4c8a60e1a@gmail.com> (raw)
In-Reply-To: <CACRpkdb3P6oQTK9FGUkMj4kax8us3rKH6c36pX=HD1_wMqcoJQ@mail.gmail.com>
On 7/2/19 2:56 PM, Linus Walleij wrote:
> On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>> @@ -236,7 +236,8 @@ static int unwind_pop_register(struct unwind_ctrl_block *ctrl,
>> if (*vsp >= (unsigned long *)ctrl->sp_high)
>> return -URC_FAILURE;
>>
>> - ctrl->vrs[reg] = *(*vsp)++;
>> + ctrl->vrs[reg] = READ_ONCE_NOCHECK(*(*vsp));
>> + (*vsp)++;
>
> I would probably even put in a comment here so it is clear why we
> do this. Passers-by may not know that READ_ONCE_NOCHECK() is
> even related to KASan.
Makes sense, I will add that, thanks!
>
> Other than that,
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
>
--
Florian
next prev parent reply other threads:[~2019-07-11 16:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 22:11 [PATCH v6 0/6] KASan for arm Florian Fainelli
2019-06-17 22:11 ` [PATCH v6 1/6] ARM: Add TTBR operator for kasan_init Florian Fainelli
2019-07-02 21:03 ` Linus Walleij
2019-07-11 16:54 ` Florian Fainelli
2019-06-17 22:11 ` [PATCH v6 2/6] ARM: Disable instrumentation for some code Florian Fainelli
2019-07-02 21:56 ` Linus Walleij
2019-07-11 16:53 ` Florian Fainelli [this message]
2019-06-17 22:11 ` [PATCH v6 3/6] ARM: Replace memory function for kasan Florian Fainelli
2019-06-17 22:11 ` [PATCH v6 4/6] ARM: Define the virtual space of KASan's shadow region Florian Fainelli
2019-06-17 22:11 ` [PATCH v6 5/6] ARM: Initialize the mapping of KASan shadow memory Florian Fainelli
2019-06-17 22:11 ` [PATCH v6 6/6] ARM: Enable KASan for arm Florian Fainelli
2019-07-02 21:06 ` [PATCH v6 0/6] " Linus Walleij
2019-07-11 17:00 ` Florian Fainelli
2019-07-18 7:51 ` Arnd Bergmann
2019-10-07 21:34 ` Florian Fainelli
2019-10-07 22:10 ` Arnd Bergmann
2019-10-08 8:47 ` Linus Walleij
2019-11-14 18:12 ` Marco Felsch
2019-11-14 23:01 ` Florian Fainelli
2019-11-15 7:08 ` Marco Felsch
2019-11-15 11:44 ` Marco Felsch
2019-11-19 0:13 ` Florian Fainelli
2020-01-17 10:13 ` Linus Walleij
2020-01-17 19:55 ` Florian Fainelli
2020-01-17 21:05 ` Linus Walleij
2020-03-05 8:43 ` Linus Walleij
2020-03-05 9:43 ` Marco Felsch
2020-03-20 9:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa45795c-7fa1-ebb8-5d26-cce4c8a60e1a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=dhowells@redhat.com \
--cc=drjones@redhat.com \
--cc=dvyukov@google.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jinb.park7@gmail.com \
--cc=julien.thierry@arm.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuwenliang@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=nico@fluxnic.net \
--cc=philip@cog.systems \
--cc=pombredanne@nexb.com \
--cc=rob@landley.net \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=vladimir.murzin@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).