From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB48C433E4 for ; Wed, 22 Jul 2020 14:51:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29801207CD for ; Wed, 22 Jul 2020 14:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bU8EdgRf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732713AbgGVOvm (ORCPT ); Wed, 22 Jul 2020 10:51:42 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49671 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729642AbgGVOvl (ORCPT ); Wed, 22 Jul 2020 10:51:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595429499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T+UMFueXPyO+OYg0tEXFd38585DEj4VDz/fSAnWATcs=; b=bU8EdgRfAVZ38ZOIJfFIEIIebHB+/cFgS7bdmPBAfnpJ9bdA9kxB84ge7FiPw6Xs8gK1db DIUEvWTgt+N+HBSQ5uynDVP0S7qXTzJlAp8qRLCY73YbedmNQJ1QAbbeu0vXreV1TuopFA Rb9On0JZSSInfKZiotLz2m4vamjrXa8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-k2Ojwp5FNQqfZxCKnHF9nQ-1; Wed, 22 Jul 2020 10:51:37 -0400 X-MC-Unique: k2Ojwp5FNQqfZxCKnHF9nQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27E79107ACCA; Wed, 22 Jul 2020 14:51:35 +0000 (UTC) Received: from [10.10.114.255] (ovpn-114-255.rdu2.redhat.com [10.10.114.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 281CB17514; Wed, 22 Jul 2020 14:51:33 +0000 (UTC) Subject: Re: [PATCH v4 00/10] Function Granular KASLR To: Kees Cook , Miroslav Benes Cc: Kristen Carlson Accardi , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, arjan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, live-patching@vger.kernel.org References: <20200717170008.5949-1-kristen@linux.intel.com> <202007220738.72F26D2480@keescook> From: Joe Lawrence Message-ID: Date: Wed, 22 Jul 2020 10:51:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <202007220738.72F26D2480@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/20 10:39 AM, Kees Cook wrote: > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote: >> Let me CC live-patching ML, because from a quick glance this is something >> which could impact live patching code. At least it invalidates assumptions >> which "sympos" is based on. > > In a quick skim, it looks like the symbol resolution is using > kallsyms_on_each_symbol(), so I think this is safe? What's a good > selftest for live-patching? > Hi Kees, I don't think any of the in-tree tests currently exercise the kallsyms/sympos end of livepatching. I do have a local branch that does facilitate creating klp-relocations that do rely upon this feature -- I'll try to see if I can get those working with this patchset and report back later this week. -- Joe