From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbcH2PsR (ORCPT ); Mon, 29 Aug 2016 11:48:17 -0400 Received: from mail-he1eur01on0086.outbound.protection.outlook.com ([104.47.0.86]:4512 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751223AbcH2PsO (ORCPT ); Mon, 29 Aug 2016 11:48:14 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH v8 4/4] nmi_backtrace: generate one-line reports for idle cpus To: Petr Mladek References: <1471377024-2244-1-git-send-email-cmetcalf@mellanox.com> <1471377024-2244-5-git-send-email-cmetcalf@mellanox.com> <20160818151211.GN13300@pathway.suse.cz> CC: Peter Zijlstra , "Rafael J. Wysocki" , Russell King , Thomas Gleixner , Aaron Tomlin , Ingo Molnar , Andrew Morton , Daniel Thompson , , , , From: Chris Metcalf Message-ID: Date: Mon, 29 Aug 2016 11:46:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160818151211.GN13300@pathway.suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN6PR1601CA0005.namprd16.prod.outlook.com (10.172.104.143) To AM4PR0501MB2754.eurprd05.prod.outlook.com (10.172.216.10) X-MS-Office365-Filtering-Correlation-Id: 7dbebdd4-3246-4539-97b1-08d3d023b93f X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;2:DaElKZAzggeabE0GA+1TwB8UDGPSzPmAoxcvcHGXcGKfVxXVBC8J4P9wwUAmx7GwoUEkp4DOqPVNk4IsBJ2nA7JTQT+e4B40CnYMmOmmRsLrcOOiB4wZpVPqBS30bY8RTjeidAoLm+LRoowKwgvwh6KaknR1ccYy4YXUE4sr5lBfvDlF2IKsesMyszSB1dkM;3:xLlz8KQSzpA40xhzclO8WVonnV4XzkMIe+RQBocw/Xt5U7klhko3M2ExdGU354ellgI1/NiACqI3s4sScFC84Ny9wfHKW0KX2I8Aao45djtPZRTWQ0yQmu2GQoghFa9S;25:GUml7QKOUsf7pmTaG5P12j/eNic6HnkbKllfe1XU1NlYZydsAkQltVAokvG524nfJWPHbiQxPQnzrjVQTR9zhxodZzXDDaBckTIlsq3k1M2/5d2mKfjQAvhYwJS4ddhl/fTM4WX9b15LCqCRbLyf4GFg8WFjfT9MrXIadKEYBH1rd7mzPolB7E42W/3r7I9SBrL5tB5oK8Wrsm76r/Xpz5w5PASe3aXVVfVMk8z5oitdo6ZmiCdJXmDxrnUtAjPBubpcCvuzr32PVosTU4y7fSvous2VsMNqtk7IK1DAyLAtCgtBd7SKyE3x4ysTwofS/GjS3Rd7S0IVjIynEPH539RJYKSkJrmq97mqe6wMN5ps4egOYUpgP09/+gQTUgDh2Kt3+7Hq48NLS8McVRyig5DfkGbcmtdDc4b37LTeSq4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0501MB2754; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;31:tnBeR2/i24oEqHt6CrHUv9Z0McnGxmryi2hnUwUqGO8835UutzrHVHOfMfEJgN6mqooC+kSCnME4/qZwOhKV9XmYJbxsSUgBkjo6G2XW39hrkEpxPBB5w4kX7nD57SgqBC4tXimaYmqmlRZnbm/Leahq9S46ViDPQXigIQPvp48GNjBWVLXmhQjc/sooBOBZkvwB69Ou/tf7uA6MqF2xd10I6fYiLrn9FwpqPm5A5sQ=;20:No5QAylZUTWMNM4Ty+75qON/zXtthafsuZibOVthaAAuL7ffJvh8gK7vUUk0jUa7IPNepkFt7xbZ6ORhbNlkbnlauz79oCRnzXv83sRi+sJ8fcoO2k1m3YkUCOdkYbkVhRlmDR3z+4AC5zrb+qOhJS9gc4fmaWRAauds51gz46HYzdOhI6w/AzW4XOqKyaotjbjwxzT0SlepNPcTvDQercxuOXbspC3BJX+QgejOrOK4izkvcnRZ4VqiMSGl12R5vYPBtyW3YLGepr6Dbcs1oPxABLXQFroU29+nOc6l7W7ibwpoRC+ieaxSIZ/X2ApLOzJzH8tmBagQrg4J1LUc/GTKVCVm4JpCAd+mFwT9VCRERHYuk26bSsWeaL6zNmcaq1UFdhYSYXkFO9/fYDLEtjIPpO0fjQF6rs/BLjSH87x4d3jaeJ/HFuw1IdmqpTopVtALRXAdIkVVymApSwiw+lK0ZJT1lzCwfewImim7zfWn0qkjG/J/Rlvf+vX5yQG0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM4PR0501MB2754;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0501MB2754; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;4:9gtnsY245JDogK0LwhbgjUE3N1LMfQmZikU3WycCCpjVeLtXtoaPzdzrCiHDMxfoUX+5RvcS90lurvzUZRD0fFa7h4VAaEREvhzaNkiVzeFE3klZboy8zQs+BjgJ7qxprnGkr/h31p7zG1lHsnssult71J5esH82yZ9EaK4gBbtVa7Mun+CA17Fs/d6ZCr7cDh5SG2Wzd45/2AC6CH0lhB84f/Erv3JY7b4iGUWQrZ3mn6O7Hz0Qm8pN1TfUDVaVE2dH5RwSbENg/R1/+sIGDioPoK18ZXqga+6ecUpjMeysNINjqp6OE96udYVeJpvAVlglQKL5iDsG5ARVgYJxKFZbxhSf7MQLEzuAM94UFfp3kX2pbfYPvtCZ9ZJAMK41zBOgnb5coT4vKePYOpab1ogiI99mAgOW/Xoy++nRwC2pdFijt5Gfo2YQdNrgu8dJpYkrmUIYxybXlv6+i74Ks26Erxw94dYwhXwfHPnZzRQ= X-Forefront-PRVS: 0049B3F387 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(199003)(377454003)(377424004)(24454002)(51444003)(189002)(64126003)(5660300001)(86362001)(15975445007)(97736004)(50986999)(4001350100001)(77096005)(6116002)(7736002)(65956001)(7846002)(4326007)(65826007)(110136002)(66066001)(65806001)(68736007)(47776003)(3846002)(586003)(81156014)(19580395003)(2950100001)(81166006)(31686004)(305945005)(106356001)(42186005)(54356999)(189998001)(2906002)(92566002)(76176999)(83506001)(33646002)(7416002)(105586002)(36756003)(50466002)(101416001)(230700001)(31696002)(8676002)(23746002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB2754;H:[10.15.7.181];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0501MB2754;23:IvmX3PTItvMJmGkw9P0XrLvx0syrYdHzp+y?= =?Windows-1252?Q?XhyH5Tiv8SZnESf5gEPuHTXtq376CsTYsPGnv7JoagBxcyeuhtYCcWT+?= =?Windows-1252?Q?KkL//QYuV/Oj0cxuczIfIUaoo+n8yXZVyhINLQ2mRapx+juSJJTMXiaw?= =?Windows-1252?Q?OUjy/DTYi5HduT2Qtn66ll1V9bSKqquHyzz38JmUzq7y8Bg7dEF1WrfG?= =?Windows-1252?Q?2XJGVj0ToRXL7FZllu1C8zCvRLa3210FXjpC5h6ocmsLAr7MphG1nbxR?= =?Windows-1252?Q?Yhh4xgi58IjVvxGO1+QnhGCUm9Hm4TGue0K8flyeDuQMCLb9KB6aW2iT?= =?Windows-1252?Q?R//CTO6UA4keUm237yV1ryg7Dz9Y3UZ8GMwqvtZ1WVfwhcTjOftuiPrd?= =?Windows-1252?Q?P2QNyU9lMIDjNURSoiOgkRzMxiYGzG9AhVaSZahY/+Fqjk9pkR+kvaY5?= =?Windows-1252?Q?jmKqajnMWHMe3cl72k9Dnvoh8C4qLvxWFRJYgFEaYFfVWELlwZp8xKg0?= =?Windows-1252?Q?gM8k94HXqj6T0oI2i8zYt4+zAkZKMGWzfbwH9PwLYNwsTVhvAtgP4P1e?= =?Windows-1252?Q?Q86Hah2ta7K62nSAOxlPddZzzbcUysGaLYUDWErajnX/q2gGSctd7J/W?= =?Windows-1252?Q?NbKSkU0ADJJkFP2tcw6F9Zh4Lkh5IBMOLKvrP1J4onjShW9me5eS4x6Z?= =?Windows-1252?Q?gHTSyaiTfwqo9tiM6FTSUN4rilc0XCTV5x3CyvEI1oig9M3Iia3ZB0vY?= =?Windows-1252?Q?lE9lGBfHpeF6mJrdneqAPYAZCNdvaDni1wkzwxY6v+meYVmoFrdMAUGe?= =?Windows-1252?Q?YLr2qIsrQcjR5kLhpoDrkYE7oe0AKt2kChU8+PX7a3+FZFfNJKi7voQP?= =?Windows-1252?Q?v6GU+90mtvffDDpq6DxuWSJYvRt3hyakf2OrVsNyEUeAjIuVBBZ/BCwu?= =?Windows-1252?Q?DmadmGovhcIqofxC/02SiOqv7PXjMdEObqA8UMmStlKkcvFaN5n5dmJy?= =?Windows-1252?Q?9UM/yZTKvYZwX15uTwB7UdizUp8PyOfSI+HxQa0yj+hYgykcgEIMCOyv?= =?Windows-1252?Q?uUI4AEa2O9iyyAAi6F7v80oeR+I1Y3Rtb0+VeuwRk/iQPccIALh/HO2D?= =?Windows-1252?Q?qSv+0z3DzUb9C3So1evZRsonhxB8Wlr4z3tmPvP53Ep2e71IRPOEED6c?= =?Windows-1252?Q?eHPHaye9jNOTiXCNZLFqEWVISHqJce4oYJjv1n1w5jThjMR9aHRYmsBV?= =?Windows-1252?Q?6wTQZ8CogXwYzRpoJujEsOsNWEu2bUXo3EcUy9uR16kPQBQjq+yk+toh?= =?Windows-1252?Q?yzXeWZgH3yS6VOfDBttYwsdMMq+DMpTJb3FS3FC14oscWuYU7RetSi1t?= =?Windows-1252?Q?hZqtzKbXoTxcWCscgzul94qThcfu82pKZ9QexX+Jsd2ohn6jU/5/SuWv?= =?Windows-1252?Q?NV4/CZ3Ulmio/6hgtDeu6Q7UsgQp9HALSYTAO2i+YcmgvALfI8IObLmj?= =?Windows-1252?Q?vXU/5OTQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;6:qEfJud2jQsRcH3rdpUNPXy925065WL1OTJiwYpas7q//8Dy1cDVAYTFkoJMZlRsSS/0+z5lh7ZwbzlclAKQGGOIRiTbJwqrBFcBBmysS0k1MaC03WVONG1NNAYdwHkGvgCBSdABzj+w+e4dLLB8kPGKcK8WRA+6B7+m/Hsn9lGJZgv/YAVFmISQuiP45hvb89cViKuP0FfYBms/8GwWVboW9fy1erMbxIZrjCKwLmRFuKBhfXU5bW6QbEaY2a8EpLMM1XgK7Gc893THVOuyZQAvBQwPADTlpPrPfeBBrQCzXkvYAfOwtImSuvh+5DLLj2PhteaAphX7TNDdR1NyChw==;5:Py4nqV7sq/iD8MO3M47KPHQl/EhBWYLICRuMdjSpOgUdQnraq9jnJOK/uj5G1J2xOB8Vl+ynE1Z3BxtlfB4wV0gDCakCtSvE5Nu+l/XyW7/qvdcdM8xetonOxVDMQ2OZQ88HXqoEecVuVnm7nRN9bw==;24:yCuGGbkPFNluKOlGI6wFUFTrCnGMdA3/Hf7BqmzyRPRRfRA2eX10LZZaA1KULeCPCCJDIV3scugs6T3QQPGztuL2AX19qR/In7uGfmU5J9o=;7:XviXqeSpk1Q3YBnXu+VK5dQhLnAdQvkGEDziQG6dXwXOplf6UwCc4E/lcYjcIGS9M4KVVIdKB0zJgTbyN0JqhmBTK6LT7WBgJ6oz5nTE/D3VU300exU9IVFrkoyJoEN2qXSAzjQvm5J2sjW1QoezpNzLRnBbm4gS9zeb/dfYVisMQwpfy3iz2tXhWr5rLEsAHBTd+ReItDlq1YA47CIJK7s4ExOqjWR/cQSWnkwBtGmQRZ4L7xHGcq9l3Y5+2GZF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2016 15:47:02.0181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2754 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/2016 11:12 AM, Petr Mladek wrote: > On Tue 2016-08-16 15:50:24, Chris Metcalf wrote: >> [...] >> -static inline void native_safe_halt(void) >> +static __always_inline void native_safe_halt(void) >> { >> asm volatile("sti; hlt": : :"memory"); >> } > Ah, the __always_inline stuff did not helped here. It was > not inlined: > > $> nm -n vmlinux | grep native_safe_halt > ffffffff81050bc0 t native_safe_halt > > The reason seems to be that it is called via > PVOP_VCALL0(pv_irq_ops.safe_halt);, see below > in the disassembly. > > I guess that it is because I have > CONFIG_PARAVIRT=y I fixed this by reverting to using __cpuidle instead of __always_inline. As you discovered, we can't use here, but I chose to just duplicate the #define of __cpuidle in instead since I think that's cleaner. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com