From: Leon Romanovsky <leon@kernel.org>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Avihai Horon <avihaih@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markzhang@nvidia.com>,
"Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Subject: [PATCH rdma-next 2/3] RDMA/core: Let ib_find_gid() continue search even after empty entry
Date: Mon, 22 Nov 2021 13:53:57 +0200 [thread overview]
Message-ID: <aab136be84ad03185a1084cb2e1ca9cad322ab23.1637581778.git.leonro@nvidia.com> (raw)
In-Reply-To: <cover.1637581778.git.leonro@nvidia.com>
From: Avihai Horon <avihaih@nvidia.com>
Currently, ib_find_gid() will stop searching after encountering the
first empty GID table entry. This behavior is wrong since neither IB
nor RoCE spec enforce tightly packed GID tables.
For example, when a valid GID entry exists at index N, and if a GID
entry is empty at index N-1, ib_find_gid() will fail to find the valid
entry.
Fix it by making ib_find_gid() continue searching even after
encountering missing entries.
Fixes: 5eb620c81ce3 ("IB/core: Add helpers for uncached GID and P_Key searches")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Mark Zhang <markzhang@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/core/device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 22a4adda7981..b5d8443030d4 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -2460,8 +2460,11 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
for (i = 0; i < device->port_data[port].immutable.gid_tbl_len;
++i) {
ret = rdma_query_gid(device, port, i, &tmp_gid);
+ if (ret == -ENOENT)
+ continue;
if (ret)
return ret;
+
if (!memcmp(&tmp_gid, gid, sizeof *gid)) {
*port_num = port;
if (index)
--
2.33.1
next prev parent reply other threads:[~2021-11-22 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 11:53 [PATCH rdma-next 0/3] Skip holes in GID tables Leon Romanovsky
2021-11-22 11:53 ` [PATCH rdma-next 1/3] RDMA/core: Modify rdma_query_gid() to return accurate error codes Leon Romanovsky
2021-12-07 18:41 ` Jason Gunthorpe
2021-11-22 11:53 ` Leon Romanovsky [this message]
2021-12-07 18:43 ` [PATCH rdma-next 2/3] RDMA/core: Let ib_find_gid() continue search even after empty entry Jason Gunthorpe
2021-12-08 6:51 ` Leon Romanovsky
2021-12-09 0:13 ` Jason Gunthorpe
2021-11-22 11:53 ` [PATCH rdma-next 3/3] RDMA/cma: Let cma_resolve_ib_dev() " Leon Romanovsky
2021-12-07 18:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab136be84ad03185a1084cb2e1ca9cad322ab23.1637581778.git.leonro@nvidia.com \
--to=leon@kernel.org \
--cc=avihaih@nvidia.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=mst@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).