From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Nianfu Bai <bnf20061983@gmail.com>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, nianfu.bai@unisoc.com,
ruifeng.zhang1@unisoc.com
Subject: Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch
Date: Fri, 4 Jun 2021 10:24:54 +0200 [thread overview]
Message-ID: <aac6c6a3-6666-075a-6901-7e3c3b2ae01d@linaro.org> (raw)
In-Reply-To: <1620716925-4329-1-git-send-email-bnf20061983@gmail.com>
On 11/05/2021 09:08, Nianfu Bai wrote:
> From: Nianfu Bai <nianfu.bai@unisoc.com>
>
> Tick broadcast installed by insmod cannot switch to oneshot mode correctly
> caused by linux timer framework, need to build in kernel image.
What timer is compiled as a module? Why the timer framework does not
allow to switch to it ?
> SPRD_TIMER
> has been selected by SPRD arch, we have to enable SPRD arch when we build
> sprd timer in kernel image, this action conflicts with general kernel image,
Why this is conflicting with general kernel image?
> so we need to remove the dependency between sprd timer and SPRD arch.
Can you rephrase the changelog, I'm not getting the point.
> Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
> ---
> drivers/clocksource/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
> Support for Mediatek timer driver.
>
> config SPRD_TIMER
> - bool "Spreadtrum timer driver" if EXPERT
> + bool "Spreadtrum timer driver" if COMPILE_TEST
> depends on HAS_IOMEM
> - depends on (ARCH_SPRD || COMPILE_TEST)
> - default ARCH_SPRD
> select TIMER_OF
> help
> Enables support for the Spreadtrum timer driver.
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-06-04 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:08 [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch Nianfu Bai
2021-05-18 7:18 ` 答复: " 柏年福 (Nianfu Bai)
2021-05-18 9:04 ` Greg KH
2021-05-19 5:53 ` 答复: " 柏年福 (Nianfu Bai)
2021-06-04 8:24 ` Daniel Lezcano [this message]
2021-06-08 2:55 ` 柏年福 (Nianfu Bai)
2021-06-08 12:08 ` Daniel Lezcano
2021-06-10 7:41 ` NFBAI
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 11:55 Nianfu Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac6c6a3-6666-075a-6901-7e3c3b2ae01d@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=bnf20061983@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nianfu.bai@unisoc.com \
--cc=ruifeng.zhang1@unisoc.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).