From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454B9C4724C for ; Fri, 1 May 2020 06:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21A81208C3 for ; Fri, 1 May 2020 06:41:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="GqsIZQEE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbgEAGlp (ORCPT ); Fri, 1 May 2020 02:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbgEAGlm (ORCPT ); Fri, 1 May 2020 02:41:42 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4413EC08E934 for ; Thu, 30 Apr 2020 23:41:41 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x4so4997339wmj.1 for ; Thu, 30 Apr 2020 23:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=GqsIZQEErtxp95UJWpKrQY3O4F4Sx0g6/X7lDuIF3bXx91ATcAP7/DgLZaXrIRReWa znotQmlfvGIU7bhOau/vG2ipCW6ay1jPpHU3dkPnfckc/TMFNyCGl5XeXfWbalOtQFX6 gHm3zFY30ObZXefKrk/18Gy2OZL756D02eheTA1eXn1hgUUuYr/zXY5w9hicdvsi4iBD i020Okt4saC0RwlJrU73As1XgAjtDLrTAZicCsFsg88M5CUlGGFssxUDRySCbpKtqxbR BDN9qezqrIubk6PtQC5phFq9yawZi0lU9ffYH6Pj6n7nOgRjbcS5uv/clrIpOkDaYgOd H9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=ISr8p4ukV+JuWw3R+xnCe8pv9xphhYIgvLW/+E/BEc6yV/3zSLSJRN7IoBgn9DUSLF APu6QY7npyTdt/vkpjvlE6i51ppGCQIqYzrW4FfI9AmWyXIoUB+EnLCxoPEGX2bxOGbW NWPRH40Z55Fys7ede2IcQGB7TBdDxFIMb4bvzTOHPFKz4RfjDZVuSEkUnQvQ/ObBg7XS TSNXGlOSY1TW4953yAobMWdMwdCyv+A/z2dUchKTGH+PLgW2ssJ3PYSik8A3w3CBgLy4 AFh3Fjc29ZDwSg3tjBQJCKkwbFwL1B5Nj+ygQe8e4wuuuj9vzwhwWwv2jG/b0408rdJ4 pJFw== X-Gm-Message-State: AGi0PuZ00T6rp69o9ypo6l1sKCylAqHNv1V0/fVWwy4xuI64JLvXQxXk 2GanU6dEVETqXG4wosDUWePrzw== X-Google-Smtp-Source: APiQypJhB8+PWaUoN3to5dH+glY2Sg5fXS6DS+6PXPXyjLj6QnarNlU5QbgDxRGc63eafm6Rtglqrg== X-Received: by 2002:a1c:e302:: with SMTP id a2mr2364418wmh.96.1588315299701; Thu, 30 Apr 2020 23:41:39 -0700 (PDT) Received: from ?IPv6:2001:16b8:48db:9b00:e80e:f5df:f780:7d57? ([2001:16b8:48db:9b00:e80e:f5df:f780:7d57]) by smtp.gmail.com with ESMTPSA id u127sm2576769wme.8.2020.04.30.23.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 23:41:39 -0700 (PDT) Subject: Re: [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private To: Al Viro , Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, Andrew Morton , "Darrick J. Wong" , William Kucharski , "Kirill A. Shutemov" , Andreas Gruenbacher , Yang Shi , Yafang Shao , Song Liu , linux-raid@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Thomas Gleixner , Sebastian Andrzej Siewior , Roman Gushchin , Andreas Dilger References: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> <20200430214450.10662-2-guoqing.jiang@cloud.ionos.com> <20200430221338.GY29705@bombadil.infradead.org> <20200501014229.GB23230@ZenIV.linux.org.uk> <20200501014954.GC23230@ZenIV.linux.org.uk> From: Guoqing Jiang Message-ID: Date: Fri, 1 May 2020 08:41:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200501014954.GC23230@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/20 3:49 AM, Al Viro wrote: > On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote: >> On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote: >> >>>> +/** >>>> + * clear_page_private - clear page's private field and PG_private. >>>> + * @page: page to be cleared. >>>> + * >>>> + * The counterpart function of attach_page_private. >>>> + * Return: private data of page or NULL if page doesn't have private data. >>>> + */ >>> Seems to me that the opposite of "attach" is "detach", not "clear". >> Or "remove", perhaps... > Actually, "detach" is better - neither "clear" nor "remove" imply "... and give > me what used to be attached there", as this thing is doing. Ok, seems we have reached the agreement about the new name ;-), will follow the instruction. Thanks & Regards, Guoqing