linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Mel Gorman <mgorman@techsingularity.net>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	Dan Streetman <ddstreet@ieee.org>, Yang Shi <shy828301@gmail.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] Clean W=1 build warnings for mm/
Date: Tue, 25 May 2021 13:48:26 +0200	[thread overview]
Message-ID: <aad3f04f-850a-b134-d0a7-b24af9721ddb@suse.cz> (raw)
In-Reply-To: <20210520084809.8576-1-mgorman@techsingularity.net>

On 5/20/21 10:47 AM, Mel Gorman wrote:
> This is a janitorial only. During development of a tool to catch build
> warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/
> is not clean for W=1. This is generally harmless but there is no harm in
> cleaning it up. It disrupts git blame a little but on relatively obvious
> lines that are unlikely to be git blame targets.
> 
>  include/asm-generic/early_ioremap.h | 9 +++++++++
>  include/linux/mmzone.h              | 5 ++++-
>  include/linux/swap.h                | 6 +++++-
>  mm/internal.h                       | 3 +--
>  mm/mapping_dirty_helpers.c          | 2 +-
>  mm/memcontrol.c                     | 2 +-
>  mm/memory_hotplug.c                 | 6 +++---
>  mm/mmap_lock.c                      | 2 ++
>  mm/page_alloc.c                     | 2 +-
>  mm/vmalloc.c                        | 3 +++
>  mm/vmscan.c                         | 2 +-
>  mm/z3fold.c                         | 2 ++
>  mm/zbud.c                           | 2 ++
>  13 files changed, 35 insertions(+), 11 deletions(-)

Thanks, looks good.

patch 3/14 subject looks like it should read just "mm/page_alloc: Make
should_fail_alloc_page a static function"

Acked-by: Vlastimil Babka <vbabka@suse.cz>



  parent reply	other threads:[~2021-05-25 11:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  8:47 [PATCH 00/14] Clean W=1 build warnings for mm/ Mel Gorman
2021-05-20  8:47 ` [PATCH 01/14] mm/vmscan: Remove kerneldoc-like comment from isolate_lru_pages Mel Gorman
2021-05-20  8:47 ` [PATCH 02/14] mm/vmalloc: Include header for prototype of set_iounmap_nonlazy Mel Gorman
2021-05-20  8:47 ` [PATCH 03/14] mm/page_alloc: Make should_fail_alloc_page a static function should_fail_alloc_page static Mel Gorman
2021-07-08 19:18   ` Matteo Croce
2021-07-09  9:30     ` Mel Gorman
2021-05-20  8:47 ` [PATCH 04/14] mm/mapping_dirty_helpers: Remove double Note in kerneldoc Mel Gorman
2021-05-20  8:48 ` [PATCH 05/14] mm/early_ioremap: Add prototype for early_memremap_pgprot_adjust Mel Gorman
2021-05-20  8:48 ` [PATCH 06/14] mm/memcontrol.c: Fix kerneldoc comment for mem_cgroup_calculate_protection Mel Gorman
2021-05-20 23:24   ` Chris Down
2021-05-20  8:48 ` [PATCH 07/14] mm/memory_hotplug: Fix kerneldoc comment for __try_online_node Mel Gorman
2021-05-20 10:42   ` David Hildenbrand
2021-05-20  8:48 ` [PATCH 08/14] mm/memory_hotplug: Fix kerneldoc comment for __remove_memory Mel Gorman
2021-05-20 10:42   ` David Hildenbrand
2021-05-20  8:48 ` [PATCH 09/14] mm/zbud: Add kerneldoc fields for zbud_pool Mel Gorman
2021-05-20  8:48 ` [PATCH 10/14] mm/z3fold: Add kerneldoc fields for z3fold_pool Mel Gorman
2021-05-20  8:48 ` [PATCH 11/14] mm/swap: Make swap_address_space an inline function Mel Gorman
2021-05-20  8:48 ` [PATCH 12/14] mm/mmap_lock: Remove dead code for !CONFIG_TRACING configurations Mel Gorman
2021-05-20  8:48 ` [PATCH 13/14] mm/page_alloc: Move prototype for find_suitable_fallback Mel Gorman
2021-05-20  8:48 ` [PATCH 14/14] mm/swap: Make NODE_DATA an inline function on CONFIG_FLATMEM Mel Gorman
2021-05-20 22:51 ` [PATCH 00/14] Clean W=1 build warnings for mm/ Yang Shi
2021-05-25 11:48 ` Vlastimil Babka [this message]
2021-05-25 14:25   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aad3f04f-850a-b134-d0a7-b24af9721ddb@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=ddstreet@ieee.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).