From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB49C433B4 for ; Wed, 31 Mar 2021 21:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 875DE601FB for ; Wed, 31 Mar 2021 21:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbhCaViy (ORCPT ); Wed, 31 Mar 2021 17:38:54 -0400 Received: from mga09.intel.com ([134.134.136.24]:11505 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbhCaVil (ORCPT ); Wed, 31 Mar 2021 17:38:41 -0400 IronPort-SDR: EppeCfZ2t4TJk7J9++CWPaAceC/HbAOUiDXPiTlSmVga0tZOVLEs21rXh7xreOGq3VAylTijk5 8nsEW6Q1ZB7A== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="192198657" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="192198657" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 14:38:41 -0700 IronPort-SDR: eTMnI4kwUh8lBZ+cBTDQzKt0wulN5uZWbQvjA/de7czjWZDmmGm8vd5ZAk9ecG3eVrPgiWjStg f3Z92azyL2EA== X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="377433229" Received: from rchatre-mobl3.amr.corp.intel.com (HELO [10.212.177.63]) ([10.212.177.63]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 14:38:40 -0700 Subject: Re: [PATCH v2 06/24] x86/resctrl: Walk the resctrl schema list instead of an arch list To: James Morse , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, Jamie Iles , D Scott Phillips OS References: <20210312175849.8327-1-james.morse@arm.com> <20210312175849.8327-7-james.morse@arm.com> From: Reinette Chatre Message-ID: Date: Wed, 31 Mar 2021 14:38:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210312175849.8327-7-james.morse@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On 3/12/2021 9:58 AM, James Morse wrote: > Once the arch code is abstracted from the resctrl filesystem code > the separate schema for CDP are created by the filesystem code. This > means the same resource is used for different schema, or types of > configuration. > > Helpers like rdtgroup_cbm_overlaps() need the resctrl_schema to > retrieve the configuration (or configurations). Before these > helpers can be changed to take the schema instead of the resource, > their callers must have the schema on hand. > > Change the users of for_each_alloc_enabled_rdt_resource() to walk > the schema instead. Schema were only created for alloc_enabled resources > so these two lists are currently equivalent. Currently equivalent? Does this mean that at some point they will not be equivalent and this change will be impacted? > > schemata_list_create() and rdt_kill_sb() are ignored. The first > creates the schema list, and will eventually loop over the resource > indexes using an arch helper to retrieve the resource. rdt_kill_sb() > will eventually make use of an arch 'reset everything' helper. Please elaborate on what "eventually" means here. It does not seem to indicate this patch series so please clarify that and any impacts. > > After the filesystem code is moved, rdtgroup_pseudo_locked_in_hierarchy() > remains part of the x86 specific hooks to support psuedo lock. This code psuedo -> pseudo Thank you Reinette