From: Andi Kleen <ak@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Add a config for max loops without consuming a packet
Date: Thu, 1 Jul 2021 10:54:53 -0700 [thread overview]
Message-ID: <aaf79640-4882-310a-e1e1-67f7818e82a0@linux.intel.com> (raw)
In-Reply-To: <20210701175132.3977-1-adrian.hunter@intel.com>
On 7/1/2021 10:51 AM, Adrian Hunter wrote:
> The Intel PT decoder limits the number of unconditional branches (e.g.
> jmps) decoded without consuming any trace packets. Generally, a loop
> needs a conditional branch which generates a TNT packet, whereas a
> "ret" instruction will generate a TIP or TNT packet. So exceeding
> the limit is assumed to be a never-ending loop, which can happen if
> there has been a decoding error putting the decoder at the wrong place in
> the code.
>
> Up until now, the limit of 10000 has been enough but some analytic
> purposes have been reported to exceed that.
>
> Increase the limit to 100000, and make it configurable via perf config
> intel-pt.max-loops. Also amend the "Never-ending loop" message to
> mention the configuration entry.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks. That is useful.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2021-07-01 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 17:51 [PATCH] perf intel-pt: Add a config for max loops without consuming a packet Adrian Hunter
2021-07-01 17:54 ` Andi Kleen [this message]
2021-07-07 14:41 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf79640-4882-310a-e1e1-67f7818e82a0@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).