From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB18C4338F for ; Tue, 3 Aug 2021 07:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CB09600CD for ; Tue, 3 Aug 2021 07:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234429AbhHCHvO (ORCPT ); Tue, 3 Aug 2021 03:51:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21345 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbhHCHvM (ORCPT ); Tue, 3 Aug 2021 03:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627977061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oYcam7agTFSd/2Q6NOTWlhklTs5e2KArUsWMeCcGGAM=; b=VdofTyAdJZV9hm305JyIHmXL7Mqfti9dV37IcC4KcHiCQeEW7g19W+inxDJkvw8DS8xOqL s0Hy3pYjBqRgLJws0uQWJQ7AIBPD1OjIlifA2nupTd+M465E2GIwkYnhlDL+oUFugi1Yyu +el3gQxdr3u/qAq65yx+8xs5E78SpcM= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-9RyG8nmLM1WJ28CLA1YnRQ-1; Tue, 03 Aug 2021 03:51:00 -0400 X-MC-Unique: 9RyG8nmLM1WJ28CLA1YnRQ-1 Received: by mail-pj1-f72.google.com with SMTP id v9-20020a17090a7c09b02901778a2a8fd6so2201382pjf.3 for ; Tue, 03 Aug 2021 00:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=oYcam7agTFSd/2Q6NOTWlhklTs5e2KArUsWMeCcGGAM=; b=Hm0qCVABUwpZPbW4RN8J9tSAPcIbHz+DK4XWq33oXVkqlVQCSCrYak1zq0OpKUv5eW AByih9BvM2C2s0ANWRfakIYAw9aBGJH3Dv7D4lluYOmCYFL3THY12KKe1L6N1CAMZBps eQl4YnCAYUYFlkGgWyLPaF7yg3TH81CPqlWeWFydPGyo8vHQvv5QTApyoYua+hXdd2on 5bpr6M+sGT6NtDDevORFybZ1MieWcrcvkDhFLG4GXKXG8HwJb5XTmHsOb6N+P/D6ln4G HoQDvETgFlyhmlxJjC5MQ9zQ9bzryWUkiTTJBNGWzEBI2PQ76YDFahClprp/KiYBT/uC qkDg== X-Gm-Message-State: AOAM533Ag0VjKBFecGuvma6ifnvzpiFAl1r4uKL0pzvza6Pfkqr0xvCb gut+rpWMOKfCMQLVMRSdbIZQ19JQH1gFAzAsYOPYuwEcusUzZhpPUCMWB2KNlgfeRzO6PrwLn0R pKbjO2k7wl5zTUsQqieuPDsjtEd5RVWi0C1pxdyrsz2WgMFwIALWeEMu519kwdESAega+BVNuL/ Wb X-Received: by 2002:a05:6a00:a8a:b029:356:be61:7f18 with SMTP id b10-20020a056a000a8ab0290356be617f18mr20640914pfl.29.1627977059323; Tue, 03 Aug 2021 00:50:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLduE7LXN7Wln37TgSE39sEWlhyZA9xOCP4JLoPOJrBqHBCOe6D/dpJAaC4v4en3vOIVKYWw== X-Received: by 2002:a05:6a00:a8a:b029:356:be61:7f18 with SMTP id b10-20020a056a000a8ab0290356be617f18mr20640860pfl.29.1627977058989; Tue, 03 Aug 2021 00:50:58 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 98sm13139744pjo.26.2021.08.03.00.50.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 00:50:58 -0700 (PDT) Subject: Re: [PATCH v10 03/17] vdpa: Fix code indentation To: Xie Yongji , mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, parav@nvidia.com, hch@infradead.org, christian.brauner@canonical.com, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net, mika.penttila@nextfour.com, dan.carpenter@oracle.com, joro@8bytes.org, gregkh@linuxfoundation.org, zhe.he@windriver.com, xiaodong.liu@intel.com, joe@perches.com Cc: songmuchun@bytedance.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-4-xieyongji@bytedance.com> From: Jason Wang Message-ID: Date: Tue, 3 Aug 2021 15:50:49 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210729073503.187-4-xieyongji@bytedance.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/7/29 ÏÂÎç3:34, Xie Yongji дµÀ: > Use tabs to indent the code instead of spaces. > > Signed-off-by: Xie Yongji > --- > include/linux/vdpa.h | 29 ++++++++++++++--------------- > 1 file changed, 14 insertions(+), 15 deletions(-) It looks to me not all the warnings are addressed. Or did you silent checkpatch.pl -f? Thanks > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 7c49bc5a2b71..406d53a606ac 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -43,17 +43,17 @@ struct vdpa_vq_state_split { > * @last_used_idx: used index > */ > struct vdpa_vq_state_packed { > - u16 last_avail_counter:1; > - u16 last_avail_idx:15; > - u16 last_used_counter:1; > - u16 last_used_idx:15; > + u16 last_avail_counter:1; > + u16 last_avail_idx:15; > + u16 last_used_counter:1; > + u16 last_used_idx:15; > }; > > struct vdpa_vq_state { > - union { > - struct vdpa_vq_state_split split; > - struct vdpa_vq_state_packed packed; > - }; > + union { > + struct vdpa_vq_state_split split; > + struct vdpa_vq_state_packed packed; > + }; > }; > > struct vdpa_mgmt_dev; > @@ -131,7 +131,7 @@ struct vdpa_iova_range { > * @vdev: vdpa device > * @idx: virtqueue index > * @state: pointer to returned state (last_avail_idx) > - * @get_vq_notification: Get the notification area for a virtqueue > + * @get_vq_notification: Get the notification area for a virtqueue > * @vdev: vdpa device > * @idx: virtqueue index > * Returns the notifcation area > @@ -342,25 +342,24 @@ static inline struct device *vdpa_get_dma_dev(struct vdpa_device *vdev) > > static inline void vdpa_reset(struct vdpa_device *vdev) > { > - const struct vdpa_config_ops *ops = vdev->config; > + const struct vdpa_config_ops *ops = vdev->config; > > vdev->features_valid = false; > - ops->set_status(vdev, 0); > + ops->set_status(vdev, 0); > } > > static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) > { > - const struct vdpa_config_ops *ops = vdev->config; > + const struct vdpa_config_ops *ops = vdev->config; > > vdev->features_valid = true; > - return ops->set_features(vdev, features); > + return ops->set_features(vdev, features); > } > > - > static inline void vdpa_get_config(struct vdpa_device *vdev, unsigned offset, > void *buf, unsigned int len) > { > - const struct vdpa_config_ops *ops = vdev->config; > + const struct vdpa_config_ops *ops = vdev->config; > > /* > * Config accesses aren't supposed to trigger before features are set.