From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69AB9C4CECD for ; Tue, 17 Sep 2019 14:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45D64214AF for ; Tue, 17 Sep 2019 14:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728089AbfIQOaV (ORCPT ); Tue, 17 Sep 2019 10:30:21 -0400 Received: from mga17.intel.com ([192.55.52.151]:53662 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfIQOaV (ORCPT ); Tue, 17 Sep 2019 10:30:21 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 07:30:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,516,1559545200"; d="scan'208";a="216585460" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2019 07:30:15 -0700 Received: from pbossart-mac01.local (unknown [10.251.11.91]) by linux.intel.com (Postfix) with ESMTP id AD906580258; Tue, 17 Sep 2019 07:30:14 -0700 (PDT) Subject: Re: [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface To: Greg KH Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, Ranjani Sridharan , vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang References: <20190916212342.12578-1-pierre-louis.bossart@linux.intel.com> <20190916212342.12578-9-pierre-louis.bossart@linux.intel.com> <20190917055512.GE2058532@kroah.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 17 Sep 2019 09:29:52 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190917055512.GE2058532@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/19 12:55 AM, Greg KH wrote: > On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote: >> +/** >> + * sdw_intel_probe() - SoundWire Intel probe routine >> + * @parent_handle: ACPI parent handle >> + * @res: resource data >> + * >> + * This creates SoundWire Master and Slave devices below the controller. >> + * All the information necessary is stored in the context, and the res >> + * argument pointer can be freed after this step. >> + */ >> +struct sdw_intel_ctx >> +*sdw_intel_probe(struct sdw_intel_res *res) >> +{ >> + return sdw_intel_probe_controller(res); >> +} >> +EXPORT_SYMBOL(sdw_intel_probe); >> + >> +/** >> + * sdw_intel_startup() - SoundWire Intel startup >> + * @ctx: SoundWire context allocated in the probe >> + * >> + */ >> +int sdw_intel_startup(struct sdw_intel_ctx *ctx) >> +{ >> + return sdw_intel_startup_controller(ctx); >> +} >> +EXPORT_SYMBOL(sdw_intel_startup); > > Why are you exporting these functions if no one calls them? They are used in the next series, see '[RFC PATCH 04/12] ASoC: SOF: Intel: add SoundWire configuration interface' +int hda_sdw_startup(struct snd_sof_dev *sdev) +{ + struct sof_intel_hda_dev *hdev; + int ret; + + hdev = sdev->pdata->hw_pdata; + + ret = sdw_intel_startup(hdev->sdw); + if (ret < 0) + return ret; + hda_sdw_int_enable(sdev, true); + + return ret; +} These 4 functions sdw_intel_acpi_scan, sdw_intel_probe, sdw_intel_startup and sdw_intel_exit are the interface between the ASoC world and the Soundwire/Intel module. I split the patches in two series to make the review and integration easier on maintainers. The first one is strictly contained within the driver/soundwire directory while will impact the soundwire and ASoC trees.