From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7930AC433EF for ; Thu, 5 May 2022 20:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385283AbiEEU5k (ORCPT ); Thu, 5 May 2022 16:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237124AbiEEU5g (ORCPT ); Thu, 5 May 2022 16:57:36 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC597B841 for ; Thu, 5 May 2022 13:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651784034; x=1683320034; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kwt3NLcQ7vZUMpzwSJrxDzlxXEiLhkkY2MWkEy+kI+8=; b=lVF9VIafqxDTxYNPgTiqEiY7QZ5m6RM5pKMhm7IDtdzxoqTxqMhbUA3i rruZ2GpcltUiv/4Ewo7P1uYcSiEUid0xu9SQy6St/+Krr5Q40M7t8pEKz QngLfSJ++nfdnkGZM6FpfOhZqmL4lDhN3oYVYj02pP9vdGzwnx3cOrpUW EjZO5/FtYNt07qpV5zd+a7RWugKukNRPXdcHHIY4wAkSXE5zUHEYZBaCY nuj5axMBfhyN7/OMX5Ky587YP3AyoMjV2CyU2axmmPiCWzdWaLZ01sOsH xgieNwq5gtfH85pblbcRg04tLbAntBNqx3adGTrBBGAjY2Im2pJDdyaMQ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="265841291" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="265841291" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 13:53:54 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="585562101" Received: from jdrobitc-mobl1.amr.corp.intel.com (HELO [10.209.123.186]) ([10.209.123.186]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 13:53:52 -0700 Message-ID: Date: Thu, 5 May 2022 13:53:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH v5 3/3] x86/tdx: Add Quote generation support Content-Language: en-US To: Kai Huang , Dave Hansen , "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org References: <20220501183500.2242828-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220501183500.2242828-4-sathyanarayanan.kuppuswamy@linux.intel.com> <243e918c523320ba3d216cbe22d24fe5ce33f370.camel@intel.com> <20220503012721.ok7fbvxmnvsr6qny@box.shutemov.name> <58d07b2d-cef5-17ed-9c57-e12fe5665e04@intel.com> <40ccd0f0-35a1-5aa7-9e51-25ab196d79e5@linux.intel.com> <2ed5c9cc316950a5a47ee714715b7980f358a140.camel@intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: <2ed5c9cc316950a5a47ee714715b7980f358a140.camel@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kai, On 5/4/22 4:28 PM, Kai Huang wrote: > On Wed, 2022-05-04 at 15:49 -0700, Sathyanarayanan Kuppuswamy wrote: >> --- a/arch/x86/coco/tdx/tdx.c >> +++ b/arch/x86/coco/tdx/tdx.c >> @@ -15,6 +15,7 @@ >>   #include >>   #include >>   #include >> +#include >> >>   /* TDX module Call Leaf IDs */ >>   #define TDX_GET_INFO                   1 >> @@ -680,8 +681,15 @@ static bool try_accept_one(phys_addr_t *start, >> unsigned long len, >>    */ >>   static bool tdx_enc_status_changed(unsigned long vaddr, int numpages, >> bool enc) >>   { >> -       phys_addr_t start = __pa(vaddr); >> -       phys_addr_t end   = __pa(vaddr + numpages * PAGE_SIZE); >> +       phys_addr_t start; >> +       phys_addr_t end; >> + >> +       if (is_vmalloc_addr((void *)vaddr)) >> +               start =  page_to_phys(vmalloc_to_page((void*)vaddr)); >> +       else >> +               start = __pa(vaddr); >> + >> +       end = start + numpages * PAGE_SIZE; >> >>          if (!enc) { >>                  /* Set the shared (decrypted) bits: */ > > Looks set_memory_decrypted() only works for direct-mapping, so you should not > use this. Instead, you can pass shared bit in 'prot' argument (using > pgprot_decrypted()) when you call vmap(), and explicitly call MapGPA(). Is it because of the above change, or you see other direct-mapping dependencies in set_memory_*() functions? > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer