From: Sinan Kaya <okaya@kernel.org>
To: Oza Pawandeep <poza@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
Wei Zhang <wzhang@fb.com>,
linux-kernel@vger.kernel.org
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Dan Williams <dan.j.williams@intel.com>,
Kees Cook <keescook@chromium.org>,
Sagi Grimberg <sagi@grimberg.me>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] PCI/AER: Clear uncorrectable error status for device
Date: Tue, 18 Sep 2018 10:30:52 -0400 [thread overview]
Message-ID: <ab1ee64e-d257-4521-1517-4c2c648d0d9c@kernel.org> (raw)
In-Reply-To: <1537258829-15763-1-git-send-email-poza@codeaurora.org>
On 9/18/2018 4:20 AM, Oza Pawandeep wrote:
> +++ b/drivers/pci/pcie/err.c
> @@ -265,6 +265,8 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev,
> * The error is non fatal so the bus is ok; just invoke
> * the callback for the function that logged the error.
> */
> + if (cb == report_resume)
> + pci_cleanup_aer_uncorrect_error_status(dev);
> cb(dev, &result_data);
> }
In order to follow the existing behavior (drivers are calling
pci_cleanup_aer_uncorrect_error_status() right before return),
you should probably move the pci_cleanup_aer_uncorrect_error_status
after
cb(dev, &result_data);
line.
next prev parent reply other threads:[~2018-09-18 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 8:20 [PATCH] PCI/AER: Clear uncorrectable error status for device Oza Pawandeep
2018-09-18 14:30 ` Sinan Kaya [this message]
2018-09-18 19:04 ` poza
2018-09-26 22:08 ` Bjorn Helgaas
2018-09-28 10:24 ` poza
2018-09-28 13:58 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1ee64e-d257-4521-1517-4c2c648d0d9c@kernel.org \
--to=okaya@kernel.org \
--cc=aacraid@microsemi.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).