From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83633C43214 for ; Wed, 4 Aug 2021 15:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B8F360F14 for ; Wed, 4 Aug 2021 15:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239421AbhHDPsz (ORCPT ); Wed, 4 Aug 2021 11:48:55 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:15478 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231506AbhHDPsw (ORCPT ); Wed, 4 Aug 2021 11:48:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1628092119; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=U04zS4aQmZ0a5D68P4sb04QFg2j4jgMCiJPHHK81Tac=; b=CX8gTTzJmPoI/jN5zw6pOMlOK5MUkuaBichgkElwFzsIYuJbWoVNZlpNuiLGRa+5W6Wg1/sa TE/2DKptkGaP/rq5QKz8PzDDRVtBssC7Nk1hJjCjyJxAHhv/C4cAwqwZwR/GRYwtksZJZ39O OitjA7nKxfvou9zYISzbms+18c4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 610ab6b51a9008a23e1c2062 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 04 Aug 2021 15:48:05 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 92BE9C43145; Wed, 4 Aug 2021 15:48:05 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2AD84C433F1; Wed, 4 Aug 2021 15:48:04 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 04 Aug 2021 08:48:04 -0700 From: khsieh@codeaurora.org To: Stephen Boyd Cc: agross@kernel.org, bjorn.andersson@linaro.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume() In-Reply-To: References: <1628007913-29892-1-git-send-email-khsieh@codeaurora.org> Message-ID: X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-03 12:05, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-08-03 09:25:13) >> Currently at dp_pm_resume() is_connected state is decided base on hpd >> connection >> status only. This will put is_connected in wrongly "true" state at the >> scenario >> that dongle attached to DUT but without hmdi cable connecting to it. >> Fix this >> problem by adding read sink count from dongle and decided is_connected >> state base >> on both sink count and hpd connection status. >> >> Changes in v2: >> -- remove dp_get_sink_count() cand call drm_dp_read_sink_count() >> >> Changes in v3: >> -- delete status local variable from dp_pm_resume() >> >> Fixes: d9aa6571b28ba ("drm/msm/dp: check sink_count before update >> is_connected status") >> Signed-off-by: Kuogee Hsieh >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 18 +++++++++++++++--- >> 1 file changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c >> b/drivers/gpu/drm/msm/dp/dp_display.c >> index 78c5301..0f39256 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -1313,7 +1313,7 @@ static int dp_pm_resume(struct device *dev) >> struct platform_device *pdev = to_platform_device(dev); >> struct msm_dp *dp_display = platform_get_drvdata(pdev); >> struct dp_display_private *dp; >> - u32 status; >> + int sink_count = 0; >> >> dp = container_of(dp_display, struct dp_display_private, >> dp_display); >> >> @@ -1327,14 +1327,26 @@ static int dp_pm_resume(struct device *dev) >> >> dp_catalog_ctrl_hpd_config(dp->catalog); >> >> - status = dp_catalog_link_is_connected(dp->catalog); >> + /* >> + * set sink to normal operation mode -- D0 >> + * before dpcd read >> + */ >> + dp_link_psm_config(dp->link, &dp->panel->link_info, false); >> + >> + /* if sink conencted, do dpcd read sink count */ > > s/conencted/connected/ > > This also just says what the code is doing. Why do we only read the > sink > count if the link is connected? Can we read the sink count even if the > link isn't connected and then consider sink count as 0 if trying to > read > fails? > yes, we can do that. But it will suffer aux time out and retry. i think it is better to avoid this overhead by check connection first. >> + if (dp_catalog_link_is_connected(dp->catalog)) { >> + sink_count = drm_dp_read_sink_count(dp->aux); >> + if (sink_count < 0) >> + sink_count = 0; >> + } >> >> + dp->link->sink_count = sink_count; >> /* >> * can not declared display is connected unless >> * HDMI cable is plugged in and sink_count of >> * dongle become 1 >> */ >> - if (status && dp->link->sink_count) >> + if (dp->link->sink_count) >> dp->dp_display.is_connected = true; >> else >> dp->dp_display.is_connected = false;