From: Jia-Ju Bai <baijiaju1990@163.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: David Miller <davem@davemloft.net>,
manish.chopra@cavium.com, rahul.verma@cavium.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct
Date: Thu, 22 Jun 2017 18:52:45 +0800 [thread overview]
Message-ID: <ab2ea6f6-330f-068a-e9dd-d2803e203b45@163.com> (raw)
In-Reply-To: <20170622060809.jvnuewiicuwtlzb4@mwanda>
On 2017/6/22 14:08, Dan Carpenter wrote:
> We should probably add a might_sleep() to ioremap() to prevent these
> bugs in the future.
I think it is right to do this.
And it will be very useful to summarize common kernel interface
functions which may sleep into a list. When writing a new driver, the
developer can refer to this list to reduce or avoid sleep-in-atomic bugs.
>
> This bug is eight years old. You can report it, but it's going to hard
> to get anyone to fix it. I sometimes ignore ancient bugs. On the other
> hand, netxen is fairly well supported so it doesn't hurt to try.
>
> I try to report bugs as soon as they are introduced. I report it to
> the author and CC the relevant list. If people don't respond to my
> email after a month then I complain again.
>
> regards,
> dan carpenter
>
Thanks for your helpful advice.
Thanks,
Jia-Ju Bai
next prev parent reply other threads:[~2017-06-22 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 2:48 [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct Jia-Ju Bai
2017-06-20 17:35 ` David Miller
2017-06-21 6:11 ` Kalle Valo
2017-06-21 6:33 ` Jia-Ju Bai
2017-06-21 13:40 ` Kalle Valo
2017-06-21 14:32 ` Jia-Ju Bai
2017-06-22 6:08 ` Dan Carpenter
2017-06-22 10:52 ` Jia-Ju Bai [this message]
2017-06-21 17:44 ` Bo Yu
-- strict thread matches above, loose matches on Subject: below --
2017-05-31 9:21 Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2ea6f6-330f-068a-e9dd-d2803e203b45@163.com \
--to=baijiaju1990@163.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.verma@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).