From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
linux- stable <stable@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
syzbot+f264bffdfbd5614f3bb2@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] bpf: Fix KASAN use-after-free Read in compute_effective_progs
Date: Mon, 23 May 2022 15:58:31 -0700 [thread overview]
Message-ID: <ab35f4fb-b058-8aa7-71f2-fab8d4a5cf26@linaro.org> (raw)
In-Reply-To: <CAEf4BzaD1Z6uOZwbquPYWB0_Z0+CkEKiXQ6zS2imiSHpTgX3pg@mail.gmail.com>
On 5/23/22 15:47, Andrii Nakryiko wrote:
>> Hi Andrii,
>> Do you have any more feedback? Does it look better to you now?
> Hi, this is on my TODO list, but I need a bit more focused time to
> think all this through and I haven't managed to get it in last week.
> I'm worried about the percpu_ref_is_zero(&desc->bpf.refcnt) portion
> and whether it can cause some skew in the calculated array index, I
> need to look at this a bit more in depth. Sorry for the delay.
That's fine. take your time and let me know if there is anything else
to change/improve. FWIW I tested it extensively with the syzbot repro
and the issue doesn't trigger anymore.
--
Thanks,
Tadeusz
next prev parent reply other threads:[~2022-05-23 22:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 17:03 [PATCH] bpf: Fix KASAN use-after-free Read in compute_effective_progs Tadeusz Struk
2022-04-12 14:44 ` Tadeusz Struk
2022-04-13 4:34 ` Andrii Nakryiko
2022-04-13 17:28 ` Tadeusz Struk
2022-04-13 19:07 ` Andrii Nakryiko
2022-04-13 19:27 ` Tadeusz Struk
2022-04-13 19:49 ` Andrii Nakryiko
2022-04-15 14:13 ` [PATCH v2] " Tadeusz Struk
2022-04-20 17:07 ` Andrii Nakryiko
2022-05-13 18:38 ` Tadeusz Struk
2022-05-13 19:08 ` [PATCH v3] " Tadeusz Struk
2022-05-16 23:16 ` Andrii Nakryiko
2022-05-16 23:35 ` Tadeusz Struk
2022-05-16 23:45 ` Andrii Nakryiko
2022-05-17 18:04 ` [PATCH v4] " Tadeusz Struk
2022-05-23 21:36 ` Tadeusz Struk
2022-05-23 22:47 ` Andrii Nakryiko
2022-05-23 22:58 ` Tadeusz Struk [this message]
2022-06-02 14:37 ` Tadeusz Struk
2022-06-02 16:11 ` Andrii Nakryiko
2022-06-02 16:25 ` Tadeusz Struk
2022-06-02 16:51 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab35f4fb-b058-8aa7-71f2-fab8d4a5cf26@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+f264bffdfbd5614f3bb2@syzkaller.appspotmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).