From: Randy Dunlap <rdunlap@infradead.org>
To: Conor Dooley <conor@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
wefu@redhat.com
Subject: Re: linux-next: Tree for Jun 21 (riscv/errata/thead)
Date: Wed, 21 Jun 2023 11:40:31 -0700 [thread overview]
Message-ID: <ab38f6af-cb68-a918-1a63-2e7c927a8ffc@infradead.org> (raw)
In-Reply-To: <20230621-playoff-wireless-0dcfce9711ff@spud>
On 6/21/23 11:31, Conor Dooley wrote:
> On Wed, Jun 21, 2023 at 11:25:14AM -0700, Randy Dunlap wrote:
>>
>>
>> On 6/20/23 21:59, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20230620:
>>>
>>
>> on riscv 32-bit:
>
> Is XIP_KERNEL enabled? And if so, does this fix it?
Yes. and Yes.
Thanks.
for your patch:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index ce10a38dff37..6833d01e2e70 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -43,6 +43,7 @@ config ARCH_SUNXI
>
> config ARCH_THEAD
> bool "T-HEAD RISC-V SoCs"
> + depends on MMU && !XIP_KERNEL
> select ERRATA_THEAD
> help
> This enables support for the RISC-V based T-HEAD SoCs.
> (whitespace damaged)
>
> Cheers,
> Conor.
>
>>
>>
>> WARNING: unmet direct dependencies detected for ERRATA_THEAD
>> Depends on [n]: RISCV_ALTERNATIVE [=n]
>> Selected by [y]:
>> - ARCH_THEAD [=y]
>>
>> WARNING: unmet direct dependencies detected for ERRATA_THEAD
>> Depends on [n]: RISCV_ALTERNATIVE [=n]
>> Selected by [y]:
>> - ARCH_THEAD [=y]
>>
>> WARNING: unmet direct dependencies detected for ERRATA_THEAD
>> Depends on [n]: RISCV_ALTERNATIVE [=n]
>> Selected by [y]:
>> - ARCH_THEAD [=y]
>>
>> ../arch/riscv/errata/thead/errata.c: In function 'errata_probe_pbmt':
>> ../arch/riscv/errata/thead/errata.c:29:22: error: 'RISCV_ALTERNATIVES_EARLY_BOOT' undeclared (first use in this function)
>> 29 | if (stage == RISCV_ALTERNATIVES_EARLY_BOOT ||
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c:29:22: note: each undeclared identifier is reported only once for each function it appears in
>> ../arch/riscv/errata/thead/errata.c:30:22: error: 'RISCV_ALTERNATIVES_MODULE' undeclared (first use in this function)
>> 30 | stage == RISCV_ALTERNATIVES_MODULE)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c: In function 'errata_probe_cmo':
>> ../arch/riscv/errata/thead/errata.c:45:22: error: 'RISCV_ALTERNATIVES_EARLY_BOOT' undeclared (first use in this function)
>> 45 | if (stage == RISCV_ALTERNATIVES_EARLY_BOOT)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c: In function 'errata_probe_pmu':
>> ../arch/riscv/errata/thead/errata.c:63:22: error: 'RISCV_ALTERNATIVES_EARLY_BOOT' undeclared (first use in this function)
>> 63 | if (stage == RISCV_ALTERNATIVES_EARLY_BOOT)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c: At top level:
>> ../arch/riscv/errata/thead/errata.c:86:37: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration
>> 86 | void thead_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
>> | ^~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c: In function 'thead_errata_patch_func':
>> ../arch/riscv/errata/thead/errata.c:95:41: error: increment of pointer to an incomplete type 'struct alt_entry'
>> 95 | for (alt = begin; alt < end; alt++) {
>> | ^~
>> ../arch/riscv/errata/thead/errata.c:96:24: error: invalid use of undefined type 'struct alt_entry'
>> 96 | if (alt->vendor_id != THEAD_VENDOR_ID)
>> | ^~
>> ../arch/riscv/errata/thead/errata.c:98:24: error: invalid use of undefined type 'struct alt_entry'
>> 98 | if (alt->patch_id >= ERRATA_THEAD_NUMBER)
>> | ^~
>> ../arch/riscv/errata/thead/errata.c:101:33: error: invalid use of undefined type 'struct alt_entry'
>> 101 | tmp = (1U << alt->patch_id);
>> | ^~
>> ../arch/riscv/errata/thead/errata.c:103:34: error: implicit declaration of function 'ALT_OLD_PTR' [-Werror=implicit-function-declaration]
>> 103 | oldptr = ALT_OLD_PTR(alt);
>> | ^~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c:103:32: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> 103 | oldptr = ALT_OLD_PTR(alt);
>> | ^
>> ../arch/riscv/errata/thead/errata.c:104:34: error: implicit declaration of function 'ALT_ALT_PTR' [-Werror=implicit-function-declaration]
>> 104 | altptr = ALT_ALT_PTR(alt);
>> | ^~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c:104:32: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> 104 | altptr = ALT_ALT_PTR(alt);
>> | ^
>> ../arch/riscv/errata/thead/errata.c:107:38: error: 'RISCV_ALTERNATIVES_EARLY_BOOT' undeclared (first use in this function)
>> 107 | if (stage == RISCV_ALTERNATIVES_EARLY_BOOT) {
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../arch/riscv/errata/thead/errata.c:108:59: error: invalid use of undefined type 'struct alt_entry'
>> 108 | memcpy(oldptr, altptr, alt->alt_len);
>> | ^~
>> ../arch/riscv/errata/thead/errata.c:111:70: error: invalid use of undefined type 'struct alt_entry'
>> 111 | patch_text_nosync(oldptr, altptr, alt->alt_len);
>> | ^~
>> cc1: some warnings being treated as errors
>>
>>
>> --
>> ~Randy
--
~Randy
next prev parent reply other threads:[~2023-06-21 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 4:59 linux-next: Tree for Jun 21 Stephen Rothwell
2023-06-21 18:25 ` linux-next: Tree for Jun 21 (riscv/errata/thead) Randy Dunlap
2023-06-21 18:31 ` Conor Dooley
2023-06-21 18:40 ` Randy Dunlap [this message]
2023-06-21 18:41 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab38f6af-cb68-a918-1a63-2e7c927a8ffc@infradead.org \
--to=rdunlap@infradead.org \
--cc=conor@kernel.org \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).