From: "Natarajan, Janakarajan" <Janakarajan.Natarajan@amd.com>
To: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
Pu Wen <puwen@hygon.com>, Borislav Petkov <bp@suse.de>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Richard Fontana <rfontana@redhat.com>
Subject: Re: [PATCHv2 0/3] Update cpupower and make it more accurate
Date: Tue, 22 Oct 2019 16:39:11 +0000 [thread overview]
Message-ID: <ab5d732b-f322-0aeb-3970-99167afc177c@amd.com> (raw)
In-Reply-To: <cover.1570819652.git.Janakarajan.Natarajan@amd.com>
On 10/11/2019 2:37 PM, Natarajan, Janakarajan wrote:
> This patchset updates cpupower to make it more accurate by removing
> the userspace to kernel transitions and read_msr initiated IPI delays.
>
> The first patch does a little re-arrangement of variables in the
> cpuidle_monitor struct to prepare for a new flag.
>
> The second patch introduces a per_cpu_schedule flag which, when set,
> will allow cpupower to move to each of the cpus in the system. The
> advantage of this is that the IPI latency is removed when reading
> the APERF/MPERF registers, since an IPI is not generated for rdmsrs
> when the source and destination cpus are the same for the IPI.
>
> The third patch introduces the RDPRU instruction, which will allow
> cpupower to not use the msr module for APERF/MPERF register reads.
> This will remove the userspace to kernel transition delays when
> reading the APERF/MPERF registers.
Any concerns regarding this patchset?
-Janak
>
> v1->v2:
> * Added cover letter.
> * Used bind_cpu instead of rewriting the same code.
> * Moved needs_root to flag sub-struct.
> * Introduced per_cpu_schedule flag.
>
> Janakarajan Natarajan (3):
> cpupower: Move needs_root variable into a sub-struct
> cpupower: mperf_monitor: Introduce per_cpu_schedule flag
> cpupower: mperf_monitor: Update cpupower to use the RDPRU instruction
>
> tools/power/cpupower/utils/helpers/cpuid.c | 4 ++
> tools/power/cpupower/utils/helpers/helpers.h | 1 +
> .../utils/idle_monitor/amd_fam14h_idle.c | 2 +-
> .../utils/idle_monitor/cpuidle_sysfs.c | 2 +-
> .../utils/idle_monitor/cpupower-monitor.c | 2 +-
> .../utils/idle_monitor/cpupower-monitor.h | 5 +-
> .../utils/idle_monitor/hsw_ext_idle.c | 2 +-
> .../utils/idle_monitor/mperf_monitor.c | 64 +++++++++++++++----
> .../cpupower/utils/idle_monitor/nhm_idle.c | 2 +-
> .../cpupower/utils/idle_monitor/snb_idle.c | 2 +-
> 10 files changed, 68 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2019-10-22 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 19:37 [PATCHv2 0/3] Update cpupower and make it more accurate Natarajan, Janakarajan
2019-10-11 19:37 ` [PATCHv2 1/3] cpupower: Move needs_root variable into a sub-struct Natarajan, Janakarajan
2019-10-11 19:37 ` [PATCHv2 2/3] cpupower: mperf_monitor: Introduce per_cpu_schedule flag Natarajan, Janakarajan
2019-10-25 10:39 ` Thomas Renninger
2019-10-25 15:33 ` shuah
2019-10-28 16:37 ` Natarajan, Janakarajan
2019-10-11 19:37 ` [PATCHv2 3/3] cpupower: mperf_monitor: Update cpupower to use the RDPRU instruction Natarajan, Janakarajan
2019-10-22 16:39 ` Natarajan, Janakarajan [this message]
2019-10-25 10:47 ` [PATCHv2 0/3] Update cpupower and make it more accurate Thomas Renninger
2019-10-25 15:18 ` shuah
2019-11-04 20:21 ` shuah
2019-11-04 21:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5d732b-f322-0aeb-3970-99167afc177c@amd.com \
--to=janakarajan.natarajan@amd.com \
--cc=allison@lohutok.net \
--cc=bp@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=puwen@hygon.com \
--cc=rfontana@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).