Re: [PATCH 4/5] scsi: libsas: Drop SAS_DPRINTK() and revise logs levels

[John Garry <john.garry@huawei.com>]

On 14/11/2018 16:39, Joe Perches wrote:
> On Wed, 2018-11-14 at 15:12 +0000, John Garry wrote:
>> On 14/11/2018 14:53, Joe Perches wrote:
>>> On Wed, 2018-11-14 at 21:47 +0800, John Garry wrote:
>>>> Like sas_printk() did previously, SAS_DPRINTK() offers little value now
>>>> that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it
>>>> can be dropped.
>>>>
>>>> However, after reviewing some logs in libsas, it is noticed that debug
>>>> level is too low in many instances.
>>>>
>>>> So this change drops SAS_DPRINTK() and revises some logs to a more
>>>> appropriate level. However many stay at debug level, although some
>>>> are significantly promoted.
>>> []
>>>> All the pre-existing checkpatch errors for spanning messages across
>>>> multiple lines are untouched.
>>>
>>> I think coalescing would be useful.
>>
>> Sorry, I missed that. Do you mean that we stop spanning strings over
>> multiple lines?
>
> Yes.
>
>> If yes, I tend to agree. It means we can grep for full strings vs just a
>> different checkpatch issue (>80 lines or spanning multiple lines)
>
> checkpatch does not emit a warning when a string is the
> last element of a line that is > 80 chars when the
> string stats before position 79.
>

That's nice.

Thanks

>
>
> .
>