From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3C2C43441 for ; Wed, 14 Nov 2018 16:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 137EF22360 for ; Wed, 14 Nov 2018 16:42:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 137EF22360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733279AbeKOCqH (ORCPT ); Wed, 14 Nov 2018 21:46:07 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:32933 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727576AbeKOCqH (ORCPT ); Wed, 14 Nov 2018 21:46:07 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C74ED8ED27117; Thu, 15 Nov 2018 00:41:31 +0800 (CST) Received: from [127.0.0.1] (10.202.226.41) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.408.0; Thu, 15 Nov 2018 00:41:27 +0800 Subject: Re: [PATCH 4/5] scsi: libsas: Drop SAS_DPRINTK() and revise logs levels To: Joe Perches , , References: <1542203269-174932-1-git-send-email-john.garry@huawei.com> <1542203269-174932-5-git-send-email-john.garry@huawei.com> <132ba0c903b36d85db30cfebf58fe1f4c3a7c05b.camel@perches.com> <6c453baa-71bb-5fe0-28a1-5af097f2e9ae@huawei.com> <89e6bbe46d4fe804f884d7cf37303d43f577ad33.camel@perches.com> CC: , , , , From: John Garry Message-ID: Date: Wed, 14 Nov 2018 16:41:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <89e6bbe46d4fe804f884d7cf37303d43f577ad33.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2018 16:39, Joe Perches wrote: > On Wed, 2018-11-14 at 15:12 +0000, John Garry wrote: >> On 14/11/2018 14:53, Joe Perches wrote: >>> On Wed, 2018-11-14 at 21:47 +0800, John Garry wrote: >>>> Like sas_printk() did previously, SAS_DPRINTK() offers little value now >>>> that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it >>>> can be dropped. >>>> >>>> However, after reviewing some logs in libsas, it is noticed that debug >>>> level is too low in many instances. >>>> >>>> So this change drops SAS_DPRINTK() and revises some logs to a more >>>> appropriate level. However many stay at debug level, although some >>>> are significantly promoted. >>> [] >>>> All the pre-existing checkpatch errors for spanning messages across >>>> multiple lines are untouched. >>> >>> I think coalescing would be useful. >> >> Sorry, I missed that. Do you mean that we stop spanning strings over >> multiple lines? > > Yes. > >> If yes, I tend to agree. It means we can grep for full strings vs just a >> different checkpatch issue (>80 lines or spanning multiple lines) > > checkpatch does not emit a warning when a string is the > last element of a line that is > 80 chars when the > string stats before position 79. > That's nice. Thanks > > > . >