From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"wen.yang99@zte.com.cn" <wen.yang99@zte.com.cn>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiang.biao2@zte.com.cn" <jiang.biao2@zte.com.cn>,
"zhong.weidong@zte.com.cn" <zhong.weidong@zte.com.cn>,
"sergey.senozhatsky.work@gmail.com"
<sergey.senozhatsky.work@gmail.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"tan.hu@zte.com.cn" <tan.hu@zte.com.cn>,
"tj@kernel.org" <tj@kernel.org>
Subject: Re: [PATCH] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk
Date: Thu, 29 Mar 2018 23:56:05 +0000 [thread overview]
Message-ID: <ab95f87c23832aed080d0c1b6f329471a26d549b.camel@wdc.com> (raw)
In-Reply-To: <1522226584-137056-1-git-send-email-wen.yang99@zte.com.cn>
On Wed, 2018-03-28 at 16:43 +0800, Wen Yang wrote:
> There would be so many same lines printed by frequent prink if one
> disk went wrong, like,
> [ 546.185242] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185258] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185280] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185307] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185334] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185364] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185390] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185410] sd 0:1:0:0: rejecting I/O to offline device
> For slow serial console, the frequent prink may block the printk, and
> if spin_lock was acquired before the printk like in scsi_request_fn,
> that could trigger the watchdog.
>
> Relative disscussion can be found here,
^^^^^^^^
Related?
Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
prev parent reply other threads:[~2018-03-29 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 8:43 [PATCH] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk Wen Yang
2018-03-29 23:56 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab95f87c23832aed080d0c1b6f329471a26d549b.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tan.hu@zte.com.cn \
--cc=tj@kernel.org \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).