From: Tsuchiya Yuto <kitakar@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Patrik Gfeller <patrik.gfeller@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Kaixu Xia <kaixuxia@tencent.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Yang Li <abaci-bugfix@linux.alibaba.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Alex Dewar <alex.dewar90@gmail.com>,
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe
Date: Tue, 09 Nov 2021 00:48:33 +0900 [thread overview]
Message-ID: <abada89901e0ca11f13d8380de8c1184522eb6db.camel@gmail.com> (raw)
In-Reply-To: <20211102130245.GE2794@kadam>
<removed Alan from Cc as the mail address not reachable>
On Tue, 2021-11-02 at 16:02 +0300, Dan Carpenter wrote:
> On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > index 366161cff560..7206d29ba263 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > @@ -1715,6 +1715,12 @@ void atomisp_wdt_refresh_pipe(struct atomisp_video_pipe *pipe,
> > {
> > unsigned long next;
> >
> > + if(!pipe->asd) {
>
> Run your patches through scripts/checkpatch.pl.
I'm sorry about this. I did checkpatch for another series I sent earlier,
but forgot this series.
Regards,
Tsuchiya Yuto
> > + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> > + __func__, pipe->vdev.name);
> > + return;
> > + }
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2021-11-08 15:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 16:23 [BUG 0/5] bug reports for atomisp to make it work Tsuchiya Yuto
2021-10-17 16:23 ` [BUG/RFC PATCH 1/5] [BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW Tsuchiya Yuto
[not found] ` <20211029100259.2cdfdfce@sal.lan>
2021-11-11 8:00 ` Tsuchiya Yuto
2021-10-17 16:23 ` [BUG/RFC PATCH 2/5] [BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid duplicate active_bo Tsuchiya Yuto
2021-10-17 16:23 ` [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe Tsuchiya Yuto
2021-11-02 13:02 ` Dan Carpenter
2021-11-02 14:44 ` Andy Shevchenko
2021-11-02 14:45 ` Andy Shevchenko
2021-11-02 15:05 ` Dan Carpenter
2021-11-02 15:49 ` Andy Shevchenko
2021-11-02 22:52 ` Mauro Carvalho Chehab
2021-11-08 15:48 ` Tsuchiya Yuto [this message]
2021-10-17 16:23 ` [BUG 4/5] [BUG] media: atomisp: `modprobe -r` not working well (dup video4linux, ATOMISP_SUBDEV_{0,1}) Tsuchiya Yuto
2021-10-17 16:23 ` [BUG 5/5] [BUG] media: atomisp: atomisp causes touchscreen to stop working on Microsoft Surface 3 Tsuchiya Yuto
2021-10-18 8:30 ` Hans de Goede
2021-10-21 9:52 ` Tsuchiya Yuto
2021-10-24 8:32 ` Hans de Goede
2021-10-26 9:35 ` Tsuchiya Yuto
2021-10-26 15:41 ` Hans de Goede
2021-10-27 16:07 ` Tsuchiya Yuto
2021-11-07 23:39 ` Hans de Goede
2021-11-08 7:41 ` Mauro Carvalho Chehab
2021-11-08 7:55 ` Hans de Goede
2021-11-08 8:01 ` Mauro Carvalho Chehab
2021-11-09 4:18 ` Tsuchiya Yuto
2021-11-09 9:08 ` Mauro Carvalho Chehab
2021-11-09 4:15 ` Tsuchiya Yuto
2021-11-09 7:35 ` Mauro Carvalho Chehab
2021-10-18 7:50 ` [BUG 0/5] bug reports for atomisp to make it work Hans de Goede
2021-10-18 8:10 ` Andy Shevchenko
2021-10-19 12:58 ` Tsuchiya Yuto
2021-10-19 14:06 ` Andy Shevchenko
2021-10-20 6:48 ` Mauro Carvalho Chehab
2021-10-20 12:35 ` Tsuchiya Yuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abada89901e0ca11f13d8380de8c1184522eb6db.camel@gmail.com \
--to=kitakar@gmail.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=alex.dewar90@gmail.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kaixuxia@tencent.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=patrik.gfeller@gmail.com \
--cc=peterz@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).