From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932774AbeAXKAp (ORCPT ); Wed, 24 Jan 2018 05:00:45 -0500 Received: from mail-cys01nam02on0054.outbound.protection.outlook.com ([104.47.37.54]:4056 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752370AbeAXKAj (ORCPT ); Wed, 24 Jan 2018 05:00:39 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v3] vfio/type1: Adopt fast IOTLB flush interface when unmap IOVAs To: Alex Williamson Cc: kvm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, joro@8bytes.org, jroedel@suse.de References: <1516595377-4681-1-git-send-email-suravee.suthikulpanit@amd.com> <20180123150452.03a42c53@w520.home> From: Suravee Suthikulpanit Message-ID: Date: Wed, 24 Jan 2018 17:00:18 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180123150452.03a42c53@w520.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [114.109.128.54] X-ClientProxiedBy: KL1PR0601CA0024.apcprd06.prod.outlook.com (10.170.160.162) To DM5PR12MB1739.namprd12.prod.outlook.com (10.175.89.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4f7eeb2e-5868-409d-de59-08d563115176 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:DM5PR12MB1739; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1739;3:N9RZbot3JrsuWVfqK50KfQvcfmPw2Z3a0ORO/Ua/761rh+p/ccACOm88P0HB+BIrk5ZcpaQCH4Ky6EX3e4fG024wwu4o5x6FNwFospUAUuLUaheYPqKefkqKLYBxijOZ6jeBQfdNFigEfLG+kvplzf5e6APGxQGMC4Zb1hsv+8+8nQJaIdQ0iW5YYgItAALy/Cnx8k+oVPIdCeoGTjXkMMhAGd9zldzr+H2Uj9WrHMTS8FvBokkHA5sp+c1on0Uc;25:zosX2aDcHU0Olx8d/GTUL3Yb4/99lW8Y1vwh0jkmVe1gOil6sWfLct3yL+RC1q+rrNL6yNoSaGNHp00ydbora5xRacsk2cob0D6mA6LIv/qCCD9OLmtJZj6piwJE5Fs5yBpkMNMHNKUpYDhFC0ZbaA+rds6hTJf8XgjYhRl/P1OvvqYMSQmjI3jSEiMErSKWWFZesPB2JJlIuGqnxs1E2e9fbOY+SWR+9xGMb/aHxfPRPa741hDHhQUFYCQ3oq36JCYCE/jVt9yXKLkK/Iw96xLYGmS/Zvt8PsepRYEZ/Y3kFtH8cqP0xjL/l4oc7I1p/Z+6w8MlPY5aP+1NSA0sAg==;31:l5CaJjUNFkVpllpWhpA28fZmx5SXRU4glvrw+SbjcyR9B8/D9uI1w/k1ndTp4olYxhlJbkKcmwy0QtHNs8mMubOVDPS0F3p6qjro45op2xa73gimVqH4CYAd06Rf4+B8OMJk33ux+vw/l+bRP5Wwob8Iv/UNwQYp0PG7rmd/Z3Bvyk6HBUNY32/CK8tRubhI5LfBT8H7E3SqXqabKDGqABJT+N//H2bufswDaYI/fwY= X-MS-TrafficTypeDiagnostic: DM5PR12MB1739: X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1739;20:SPt2TN7mLyJ24xfZMhgxv1F2V69ZVEDRkG6h92bC+BG/cA6sCK0yRDjpqPR/G1JB88+OEQFH0xLs2Ne4Pluw2S0wzrQgv0QxGtlXqogsQf+Kh5iH70id9tmKkUeyMEuNnlmJGGg7jHTQfXwPmH6TTwW4X0pvnovezpcrfdRZk0NJAyGaGjiBMn8J1bpOOcCwfsaTlXoYcJrgkEGfdXgYchwCkh/JCw0l2Y5ykbJ2iN+aQw68FZ09+UyHHA90vmA6w2qrLie0C5abKgkN2sLZPGo72yUJBxEPdIhTtVk9sqt4VBlhHdG46KzwaN8mZh9FZidKLB0+RHKVFasjJJ4h/PAwr69By0u64dB62EtEZVojFTLnsXKut5QA/xDPMiV7gg3OZeFFoNILNLzZ6R7pkxuidyl3R5ZbcyNe4Xw7qD+vhKHMlEK7k3hxPJsHAg50aboBa5lpaKbEVRqw89vzo1taLlHHOjYrk5LxrT/bMMMU/KgyK4Jx2dGJ//Q+VPMr;4:vNWAlYKkcQiN4wDKTWI577r2qCdZ2AD6M/7Xr1xRqtAAqxhR9wtOFRDBAF7UEH4FzaTqmHx/UkTWNKEIgM++dOEU+xwXssKVdzgVz3RIxQ92zftgMzEGat4bPB+wrYZ0WG80DqsKUYj0ToFVcg5EbqP8UtMJ1cSWgYrHJcX5rnjgxq/hBgfpV5e0VKcCqauCgRLk2tP6dxHyZwtGdHWZ1aE1g8Rcc7lo5auZoRYq0HFJ52XfEHNxKKvjMQIRQbPDQU0SjHlYGrQuP+pNJQ95zQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR12MB1739;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1739; X-Forefront-PRVS: 056297E276 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(366004)(376002)(346002)(39860400002)(39380400002)(396003)(199004)(189003)(6666003)(31686004)(478600001)(230700001)(106356001)(8936002)(105586002)(6916009)(72206003)(316002)(2950100002)(229853002)(67846002)(25786009)(3846002)(305945005)(86362001)(2906002)(7736002)(53936002)(50466002)(6116002)(65826007)(31696002)(97736004)(5660300001)(23676004)(52146003)(52116002)(2486003)(76176011)(83506002)(81166006)(53546011)(386003)(81156014)(4326008)(68736007)(8676002)(6506007)(47776003)(64126003)(26005)(65956001)(58126008)(66066001)(6246003)(16526018)(65806001)(36756003)(6486002)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1739;H:Suravees-MacBook-Pro-15.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNzM5OzIzOjJYQjg5MFhsWVlRYTJEcmYzbW05UERrQnda?= =?utf-8?B?cTNldm9JSGs4MDN0V1AxbXd3dTNDQ3V1QkNFSFRvTzJsT1dmVFR0azJEWEpU?= =?utf-8?B?cFM1K1JmdlN5NzlBZkEybmdGYkgweU84OXE1OFFBSExHNjBOeFoxZE01V3pJ?= =?utf-8?B?YjR3dUpKMWlSZDl3cnd3cW16K2YrOGhhRlBNSk1mbG1mZDNNTWtSaDRGMnpZ?= =?utf-8?B?QXAvcmVwMHRudU54NTFhbUdrTHVSa1lxaEFhQWFsaWFhTHUrb3JBSG41Z1R3?= =?utf-8?B?TEpwTng4MmtQTUozcytjNXpFNnFaWThLd0xoQ0dZM3pEYmU2UVJCMVdNcTll?= =?utf-8?B?aGdyNng0WDRUZjUzdWkzUTU2Y0wyelozL0czdi9aclI3RTQ1OTZFVC80Y3h3?= =?utf-8?B?RDBBTWwwVTFBak9reE95TW9BUlcrcExnbFZpd3RVUFNXVUtWWEkydS83SVlX?= =?utf-8?B?dy8wNXFkakx5c1V4V0xpRmVlSU9qeVVtMUJYWVdaVTk2cHM2bGNEbTR4Zld1?= =?utf-8?B?cWFERi9YOVVXc1R0M1Z2MWppTUYvWGlNN2ZDRDloOCswektJcU0xSnAwMnc4?= =?utf-8?B?K0E1Y0lFRGJ4aisvdkNkOE8wN0N4eVNTNWZNOEIzSTJaMGNFLzc5cG5OQ2Ja?= =?utf-8?B?MkdHemJIRjJ4MnJnbTB5Nlc2T3N2VmNPa3J4R0RMaTVDTUxXZUxHdnduVS9K?= =?utf-8?B?Z1pjczUxOUc0aVlUSE5kMHZRbzZFYTh4MG5lZ3Yxd2h4cnhseUpJdDJyY3pq?= =?utf-8?B?QkdDMGk1cFpjM1c4RmszL090TGQ3UEl0cE1nQjNZNVJvaGs2eHA0RGRZamFz?= =?utf-8?B?NmtvM1NXYW1oZkVVanlQYUJZMzZWaGZXR2dUSXZ4L0xFSEJsWWU3TCtOK2lr?= =?utf-8?B?dWZsTFJHcjdDMkJwcTBYbmk3U2NpQTgrL2tMZFNteGo4dXcwbkxidUkvR0Fs?= =?utf-8?B?V0ZYa2szNGlBbmlid1VYSFhlbTNaWDkwUTBoVDdOZDhnU1BRY0Z3ckEvRjVT?= =?utf-8?B?L2NqMmZtelFaWWN2UTRQeHpqbkJ1VElSLzY1WGZxQ2ZyT0ZXaVFQRVpScEZl?= =?utf-8?B?QzNuUk9pM3RlZ251MGlKUkJSOTkwczRERU5vS3hYVGZlZGxtZG9zQS95Y0h3?= =?utf-8?B?a1ZjN1JLQ1oxcXVFTzBJdUZoN3pPZnRIVTEwNTlRV3pFakhFWit0aUJ1aXdu?= =?utf-8?B?VFR1VVNWNXM3S1ArMVVvSDVCT2gvM1I5Ty9yZmhMT2Z6MHpwN0dZcG4yakR0?= =?utf-8?B?TE16b1VSaXhBUXJ2d01DQ3RpQmlkL2pVajhTTndITG40SWkrZGZMNDFwbE50?= =?utf-8?B?MjI5WUZ1M3FzUS9WQ0IvNEhsejM4WVBuaWNjZ1N3Y29qK0Viak1iWWVVUkpE?= =?utf-8?B?NEFsZlRRYWlWeTVOSDRMTXpUZkJNT3kyRjcyMDhpUWJBWEZrNjJnWnV3RUZs?= =?utf-8?B?VjhiUkQxblRwb251a216Z3VzdjltRzBucGxzNHRqUG5HMDFRd1c0NkZMWHFX?= =?utf-8?B?OGYyTGt0eGZvazRCeFZEZ1BjSWg3ZVV0eWZ3M3dCY3Bxb0lZZkZOUUxtcXNH?= =?utf-8?B?ZzdjclBSV1VEd0RnVlFJUjRsUm1mVnc3bUJFT0dXcmhydkZHd1k2UVZRdUlK?= =?utf-8?B?VWs0UTBvTU55TVcvbCtkbXpLWExPTm9tK3BFcnRzODFaRWQ2NVZrT0tOQ29o?= =?utf-8?B?cHhnTDdVVXBGc1ZhVnI4amJ1dzM0bWJaTEdjQ1UwS3hkRVNid3FUcjJ5bnlU?= =?utf-8?B?M3ZZeFdiUDBFS0NYVHZnaGpXcHoxYmVvT0ttNlZRM0RraDE2V1dzT0lVTkd4?= =?utf-8?B?eFVPemJRZ20zd1BQMTFUZUpkNDVBVnA3aDhXdUJVSnQxQWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1739;6:5kfRMGJzGRatgZSI8L2yAX69//f+1nChU11Y/LWJgCCX6fNVtC7KZsxynhUbQZu+wcXQAyIJzrDFH5fTWqlsRCVgVzz5Jl6NPhHZGzCVzSvvLZ7+BKaNXCYiYKkJ9zn842ehju4y8ZwqvRzTXVeASwLDNmpBxKiA+gCaGMq6FG6L4bEx3nM73ExajstpTzRSpD6nIQ+Y0YEpbUAgHwwa/qoXaiyC4Iivf4DXanJfBJ/yTwzyDPC8FgnWNdOdQ+ABZpwRVOaIXoF5ADUauDQsTLI8V96ktt7/bCeaieu+Ix5221tcMsfV3vHGcFXAHLW9/ASgsejERTvdJsQFUr2BjEZQA2iYQduVNR6EA6YbmFc=;5:am0tbLQeNnCDpx3KW6tDuEzjKFqi8YvL4RBXoZtpn59Yq2PtmCE0CDf2eKNdGsV3Ze5DzMaWfT0BUkbKnBaIeJXtIW3hj8xdzGcWnQMqVKCoXNUZ6yzDG/4ceg1eg69XcLl2Zmkb0IBDQg686TvQnk89/0GJlFp1Ea01KpAA2NI=;24:jMr3uwwC+6aNo6gpZ2oeyA0tlTnZXvoBw0U3xyW3Q6Hq444OLHlBqHcIpLLBgdTviHQtgvSNhl6vaV8jFEZkT04bzWaermG//INDeseIYxk=;7:B5hWUGCYN6lNyPPtj/RHAJolN9/PEQUQMCu5JslWV9bzTQQtvPLYJv5pB9UatbxIRox3zlaQ6h/hNxrEZn2BPJlV0fZtJVWXpsbMxWMWh3ygcdFgftjz9kHjjF9iWac+TJaIiRrZCJiYytqDVq9TKrz8/VyVHSUs2ynA1HfDKYWvW6fj3PaqWDy5nd6cKIa6+ep85V+P2cJNGRfJB218S0JivGftIEfnK21xqaMH0UhYattr5Zy5/1aDRXMzOs65 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1739;20:DSajxdhGbrqZO8dky5LogSotiQHqriDDyeeKoihJoPfKzNIXfR7QfYAPbp+gyWTiVH+Kx54HH9PN2uLhHa1QnVHaXEOTc+kXqZMdt5+WpUBBqfrukuqaYP7u4BCeJPckJL0kBe8x5drmkjeYb4skMnP5ph1KrSWx2tFvdlWdtZtoki+YOUPTH04ABnNnBJrYjkX9PdRRnl9WOusvW+F1KoTbelF8Yduragq6fakbHHkSpSGDryln0WJpRVdeF3oq X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2018 10:00:35.3412 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7eeb2e-5868-409d-de59-08d563115176 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1739 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex / Joerg, On 1/24/18 5:04 AM, Alex Williamson wrote: >> @@ -648,12 +685,40 @@ static int vfio_iommu_type1_unpin_pages(void *iommu_data, >> return i > npage ? npage : (i > 0 ? i : -EINVAL); >> } >> >> +static size_t try_unmap_unpin_fast(struct vfio_domain *domain, dma_addr_t iova, >> + size_t len, phys_addr_t phys, >> + struct list_head *unmapped_regions) >> +{ >> + struct vfio_regions *entry; >> + size_t unmapped; >> + >> + entry = kzalloc(sizeof(*entry), GFP_KERNEL); >> + if (!entry) >> + return -ENOMEM; >> + >> + unmapped = iommu_unmap_fast(domain->domain, iova, len); >> + if (WARN_ON(!unmapped)) { >> + kfree(entry); >> + return -EINVAL; >> + } > Not sure about the handling of this, the zero check is just a > consistency validation. If there's nothing mapped where we think there > should be something mapped, we warn and throw out the whole vfio_dma. > After this patch, such an error gets warned twice, which doesn't > really seem to be an improvement. > Since iommu_unmap() and iommu_unmap_fast() can return errors, instead of just zero check, we should also check for errors, warn, and bail out the whole vfio_dma. Thanks, Suravee