From: Florian Fainelli <f.fainelli@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: linux-next: build warnings after merge of the broadcom tree
Date: Tue, 4 Oct 2022 19:29:50 -0700 [thread overview]
Message-ID: <abbe10d1-4c2a-5fad-3f92-e55c514d3ce2@gmail.com> (raw)
In-Reply-To: <20221005114841.4540d325@canb.auug.org.au>
On 10/4/2022 5:48 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 31 Aug 2022 09:16:54 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> On Mon, 15 Aug 2022 10:54:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
>>>>
>>>> On 25.07.2022 01:59, Stephen Rothwell wrote:
>>>>> After merging the broadcom tree, today's linux-next build (arm
>>>>> multi_v7_defconfig) produced these warnings:
>>>>>
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)
>>>>
>>>> This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
>>>> basic PCI controller properties") reduced following warnings:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
>>>> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
>>>> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
>>>> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> down to this one:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> and basically does the right thing (adds required properties).
>>>>
>>>>
>>>> I'm fully aware "ranges" need to be added (it's mentioned in the commit)
>>>> and it's one of next things on my BCM5301X list.
>>>>
>>>> So while my commits triggers that problem it also reduces warnings so
>>>> I'd say it's acceptable.
>>
>> Not from my point of view: I was not getting any warnings and now I am
>> getting 254 lines of warnings :-(
>>
>>> So, is something being done about these introduced warnings?
>>
>> I am still seeing these warnings.
>>
>> The above commit is now
>>
>> 61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")
>
> Has any progress been made with this? This commit is now in the
> arm-soc tree.
Yes, I was hoping to get some feedback on this patch:
https://lore.kernel.org/all/20220920210213.3268525-1-f.fainelli@gmail.com/
but I suppose being the ARM SoC maintainer I can just go ahead and push it.
--
Florian
next prev parent reply other threads:[~2022-10-05 2:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 23:59 linux-next: build warnings after merge of the broadcom tree Stephen Rothwell
2022-07-25 10:33 ` Rafał Miłecki
2022-08-15 0:54 ` Stephen Rothwell
2022-08-30 23:16 ` Stephen Rothwell
2022-10-05 0:48 ` Stephen Rothwell
2022-10-05 2:29 ` Florian Fainelli [this message]
2022-10-05 6:02 ` Joel Stanley
2022-10-05 7:21 ` Arnd Bergmann
2022-10-06 0:17 ` Stephen Rothwell
2022-10-06 5:14 ` Rafał Miłecki
2022-10-06 23:30 ` Stephen Rothwell
2022-10-05 5:43 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abbe10d1-4c2a-5fad-3f92-e55c514d3ce2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rafal@milecki.pl \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).