From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D43C433E0 for ; Thu, 18 Feb 2021 03:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 250AF64E3E for ; Thu, 18 Feb 2021 03:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbhBRDGr (ORCPT ); Wed, 17 Feb 2021 22:06:47 -0500 Received: from foss.arm.com ([217.140.110.172]:43262 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbhBRDGq (ORCPT ); Wed, 17 Feb 2021 22:06:46 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0BE6D1FB; Wed, 17 Feb 2021 19:05:58 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 881ED3F694; Wed, 17 Feb 2021 19:05:55 -0800 (PST) Subject: Re: [PATCH V3 14/14] coresight: etm-perf: Add support for trace buffer format To: Al Grant , Peter Zijlstra Cc: "coresight@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lcherian@marvell.com" , "mike.leach@linaro.org" References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-15-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Thu, 18 Feb 2021 08:35:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 6:30 PM, Al Grant wrote: >>> +/* CoreSight PMU AUX buffer formats */ >>> +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT0x0000 /* >> Default for backward compatibility */ >>> +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW0x0100 /* >> Raw format of the source */ >> >> Would CORESIGHT_FORMAT_ETR / CORESIGHT_FORMAT_TRBE be better >> names? > > Unformatted (raw) streams could be used any time you had a writer dedicated > to a single trace source. So in a situation where you had one ETR per CPU, > it would be appropriate to use an unformatted stream. A TRBE is always > dedicated to a single CPU, but potentially you (i.e. when designing the system) > can do this with any type of trace sink. So the raw/formatted distinction is > really about whether you are combining multiple streams in one buffer or not, > rather than the type of block that is writing into the buffer. > > Al > Okay, will stick with the proposed format names here i.e PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW