From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE55C43331 for ; Mon, 11 Nov 2019 05:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A794620818 for ; Mon, 11 Nov 2019 05:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfKKFCi (ORCPT ); Mon, 11 Nov 2019 00:02:38 -0500 Received: from www1102.sakura.ne.jp ([219.94.129.142]:62222 "EHLO www1102.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfKKFCi (ORCPT ); Mon, 11 Nov 2019 00:02:38 -0500 X-Greylist: delayed 3600 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Nov 2019 00:02:36 EST Received: from fsav108.sakura.ne.jp (fsav108.sakura.ne.jp [27.133.134.235]) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id xAB3U1uw022710; Mon, 11 Nov 2019 12:30:01 +0900 (JST) (envelope-from katsuhiro@katsuster.net) Received: from www1102.sakura.ne.jp (219.94.129.142) by fsav108.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav108.sakura.ne.jp); Mon, 11 Nov 2019 12:30:01 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav108.sakura.ne.jp) Received: from [192.168.1.2] (121.252.232.153.ap.dti.ne.jp [153.232.252.121]) (authenticated bits=0) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id xAB3U0F8022658 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NO); Mon, 11 Nov 2019 12:30:01 +0900 (JST) (envelope-from katsuhiro@katsuster.net) Subject: Re: [PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64 To: Vasily Khoruzhick Cc: Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-kernel , arm-linux References: <20190907174833.19957-1-katsuhiro@katsuster.net> From: Katsuhiro Suzuki Message-ID: Date: Mon, 11 Nov 2019 12:30:00 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Vasily, Thank you for reporting. On 2019/11/11 9:17, Vasily Khoruzhick wrote: > On Sat, Sep 7, 2019 at 10:48 AM Katsuhiro Suzuki > wrote: >> >> This patch adds audio codec (Everest ES8316) and I2S audio nodes for >> RK3399 RockPro64. > > Hi Katsuhiro, > > I tested your patch with my rockpro64 on 5.4-rc6 which has your other > patches to es8316 driver, but apparently it doesn't work. > > 'alsamixer' complains 'cannot load mixer controls: No such device or > address' and if I try to play audio with mpg123 it pretends that it > plays something but there's no sound. > > Any idea what can be wrong? > Do you use defconfig? If so I guess we need turn on more configs: - simple-graph-card driver (CONFIG_SND_AUDIO_GRAPH_CARD) - ES8316 (SND_SOC_ES8316) FYI) ASoC related status or logs in my environment as follows: root@rockpro64:~# uname -a Linux rockpro64 5.4.0-rc6-next-20191108 #169 SMP PREEMPT Mon Nov 11 12:21:44 JST 2019 aarch64 GNU/Linux root@rockpro64:~# dmesg | grep -i asoc [ 21.509903] asoc-simple-card hdmi-sound: i2s-hifi <-> ff8a0000.i2s mapping ok [ 21.510550] asoc-simple-card hdmi-sound: ASoC: no DMI vendor name! [ 21.567906] asoc-audio-graph-card sound: ES8316 HiFi <-> ff890000.i2s mapping ok [ 21.568565] asoc-audio-graph-card sound: ASoC: no DMI vendor name! root@rockpro64:~# cat /proc/asound/pcm 00-00: ff8a0000.i2s-i2s-hifi i2s-hifi-0 : ff8a0000.i2s-i2s-hifi i2s-hifi-0 : playback 1 01-00: ff890000.i2s-ES8316 HiFi ES8316 HiFi-0 : ff890000.i2s-ES8316 HiFi ES8316 HiFi-0 : playback 1 : capture 1 root@rockpro64:~# cat /sys/kernel/debug/asoc/components hdmi-audio-codec.3.auto ff8a0000.i2s ff8a0000.i2s ff890000.i2s ff890000.i2s ff880000.i2s ff880000.i2s es8316.1-0011 snd-soc-dummy snd-soc-dummy root@rockpro64:~# cat /sys/kernel/debug/asoc/dais i2s-hifi ff8a0000.i2s ff890000.i2s ff880000.i2s ES8316 HiFi snd-soc-dummy-dai Best Regards, Katsuhiro Suzuki > Regards, > Vasily > >> Signed-off-by: Katsuhiro Suzuki >> --- >> .../boot/dts/rockchip/rk3399-rockpro64.dts | 28 +++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >> index 0401d4ec1f45..8b1e6382b140 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >> @@ -81,6 +81,12 @@ >> reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; >> }; >> >> + sound { >> + compatible = "audio-graph-card"; >> + label = "rockchip,rk3399"; >> + dais = <&i2s1_p0>; >> + }; >> + >> vcc12v_dcin: vcc12v-dcin { >> compatible = "regulator-fixed"; >> regulator-name = "vcc12v_dcin"; >> @@ -470,6 +476,20 @@ >> i2c-scl-rising-time-ns = <300>; >> i2c-scl-falling-time-ns = <15>; >> status = "okay"; >> + >> + es8316: codec@11 { >> + compatible = "everest,es8316"; >> + reg = <0x11>; >> + clocks = <&cru SCLK_I2S_8CH_OUT>; >> + clock-names = "mclk"; >> + #sound-dai-cells = <0>; >> + >> + port { >> + es8316_p0_0: endpoint { >> + remote-endpoint = <&i2s1_p0_0>; >> + }; >> + }; >> + }; >> }; >> >> &i2c3 { >> @@ -505,6 +525,14 @@ >> rockchip,playback-channels = <2>; >> rockchip,capture-channels = <2>; >> status = "okay"; >> + >> + i2s1_p0: port { >> + i2s1_p0_0: endpoint { >> + dai-format = "i2s"; >> + mclk-fs = <256>; >> + remote-endpoint = <&es8316_p0_0>; >> + }; >> + }; >> }; >> >> &i2s2 { >> -- >> 2.23.0.rc1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >