From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: rohm-bdXXX - switch to use i2c probe_new
Date: Wed, 15 Apr 2020 11:44:36 +0000 [thread overview]
Message-ID: <abcb3356c78758cb176947fba7b2f291d63055a3.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20200415110405.GJ2167633@dell>
On Wed, 2020-04-15 at 12:04 +0100, Lee Jones wrote:
> On Wed, 15 Apr 2020, Vaittinen, Matti wrote:
> > Hello Lee,
> >
> > On Wed, 2020-04-15 at 10:50 +0100, Lee Jones wrote:
> > > On Thu, 26 Mar 2020, Matti Vaittinen wrote:
> > >
> > > > ROHM BD70528 and BD718x7 drivers do not utilize the I2C id.
> > > > Do the trivial conversion and make them to use probe_new
> > > > instead of probe.
> > >
> > > Not sure I understand the purpose of the patch.
> > >
> > > The only reason to switch to probe_new is to aid the removal of
> > > the
> > > compulsory I2C tables. However, neither of these drivers have
> > > them.
> >
> > Maybe I have misunderstood the probe_new. My understanding was that
> > the
> > probe_new is what should become the standard - Eg. eventually all
> > I2C
> > drivers would use probe which is not getting the ID tables as
> > argument
> > - and the old probe could be removed. Thus I thought conversion of
> > probe to probe_new would be required in order to get rid of the old
> > probe. I think I got this understanding when I submitted driver for
> > BD71828 - and I think it was you who suggested me to switch to
> > probe_new as 'id' was unused. But if please just drop this patch if
> > this change is not needed!
>
> Some I2C drivers do make use of 'id' though. So the standard probe
> will probably never go away. I wrote probe_new for drivers that
> wished to omit the I2C table. A better use of your time would be to
> go through the original probe users and figure out which I2C tables
> can be removed.
Right. Unfortunately I don't have problems with excessive amounts of
free time xD I did this probe-conversion for bd718x7 because that
driver is originally written by me - and I try to contribute on
maintenance of stuff I have pushed on your and other maintainer's
shoulders :)
And as I said - if the usage of probe is just as fine as usage of
probe_new - then please just drop this patch :)
Thanks for clarifying this!
Best Regards
Matti
next prev parent reply other threads:[~2020-04-15 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 6:48 [PATCH] mfd: rohm-bdXXX - switch to use i2c probe_new Matti Vaittinen
2020-04-15 9:50 ` Lee Jones
2020-04-15 10:49 ` Vaittinen, Matti
2020-04-15 11:04 ` Lee Jones
2020-04-15 11:44 ` Vaittinen, Matti [this message]
2020-04-16 6:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abcb3356c78758cb176947fba7b2f291d63055a3.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).