From: Alex G <mr.nuke.me@gmail.com>
To: Alex Williamson <alex.williamson@redhat.com>,
bhelgaas@google.com, helgaas@kernel.org,
linux-pci@vger.kernel.org
Cc: austin_bolen@dell.com, alex_gagniuc@dellteam.com,
keith.busch@intel.com, Shyam_Iyer@Dell.com, lukas@wunner.de,
okaya@kernel.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation
Date: Tue, 23 Apr 2019 12:59:26 -0500 [thread overview]
Message-ID: <abe311e9-85e6-27a6-e6ad-d7e8e103578f@gmail.com> (raw)
In-Reply-To: <155597243666.19387.1205950870601742062.stgit@gimli.home>
On 4/22/19 5:43 PM, Alex Williamson wrote:
> On systems that don't support any PCIe services other than bandwidth
> notification, pcie_message_numbers() can return zero vectors, causing
> the vector reallocation in pcie_port_enable_irq_vec() to retry with
> zero, which fails, resulting in fallback to INTx (which might be
> broken) for the bandwidth notification service. This can resolve
> spurious interrupt faults due to this service on some systems.
>
> Fixes: e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidth notification")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
+1
Tested on some Dell servers. Everything works as expected. I don't have
a system with a device that only supports bandwidth notification.
Alex
next prev parent reply other threads:[~2019-04-23 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 22:43 [PATCH] PCI/LINK: Account for BW notification in vector calculation Alex Williamson
2019-04-23 0:05 ` Alex G
2019-04-23 0:33 ` Alex Williamson
2019-04-23 14:33 ` Alex G
2019-04-23 15:34 ` Alex Williamson
2019-04-23 15:49 ` Lukas Wunner
2019-04-23 16:03 ` Alex G
2019-04-23 16:22 ` Alex Williamson
2019-04-23 16:27 ` Alex G
2019-04-23 16:37 ` Alex Williamson
2019-04-23 17:10 ` Bjorn Helgaas
2019-04-23 17:53 ` Alex G
2019-04-23 18:38 ` Alex Williamson
2019-04-23 17:59 ` Alex G [this message]
2019-05-01 20:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe311e9-85e6-27a6-e6ad-d7e8e103578f@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=Shyam_Iyer@Dell.com \
--cc=alex.williamson@redhat.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=okaya@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).