From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00691C433F5 for ; Wed, 23 Mar 2022 01:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240709AbiCWBy6 (ORCPT ); Tue, 22 Mar 2022 21:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231530AbiCWByz (ORCPT ); Tue, 22 Mar 2022 21:54:55 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 158A353E34; Tue, 22 Mar 2022 18:53:22 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.31:44820.495833220 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.31]) by 189.cn (HERMES) with SMTP id EF32B1002A9; Wed, 23 Mar 2022 09:53:15 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-b7fbf7d79-bwdqx with ESMTP id 437bde2d691948a680665d3a4e627624 for jiaxun.yang@flygoat.com; Wed, 23 Mar 2022 09:53:20 CST X-Transaction-ID: 437bde2d691948a680665d3a4e627624 X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn Message-ID: Date: Wed, 23 Mar 2022 09:53:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Content-Language: en-US To: Jiaxun Yang , Maxime Ripard , Thomas Zimmermann , Roland Scheidegger , Zack Rusin , Christian Gmeiner , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer , Dan Carpenter , Krzysztof Kozlowski , Andrey Zhizhikin , Sam Ravnborg , "David S . Miller" , Lucas Stach , Maarten Lankhorst , Ilia Mirkin , Qing Zhang , suijingfeng Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20220321162916.1116541-1-15330273260@189.cn> <20220321162916.1116541-3-15330273260@189.cn> <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com> <2c671752-6684-f87b-7b2d-90568d36adde@189.cn> <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/23 00:06, Jiaxun Yang wrote: > > > 在 2022/3/22 13:38, Sui Jingfeng 写道: >> >> On 2022/3/22 21:05, Jiaxun Yang wrote: >>> >>> >>> 在 2022/3/21 16:29, Sui Jingfeng 写道: >>>> From: suijingfeng >>>> >>>> The board name is LS3A4000_7A1000_EVB_BOARD_V1.4, it consist of 1.8Ghz >>>> mips64r5 4-core CPU and LS7A1000 bridge chip. It has PCIe GEN2 x8 >>>> slot, >>>> therefore can play with discrete graphics card. >>> >>> Hi Jingfeng, >>> >>> As we've discussed before if you are going to introduce new dts then >>> you *MUST* >>> include it in makefile and wire it up in code. >>> >>> A dts file doing nothing lying in the tree is just suspicious. >>> >>> Thanks. >>> - Jiaxun >>> >> Hi, Jiaxun, >> >> I know what you means, but it is the kernel side developer's job. >> I am just a naive graphic driver developer,I can not care so much. >> Below is my private patch which can be used to built specific dts >> into the linux kernel, therefore make the verification easier. > Hi Jingfeng, > > In kernel world we take care all the stuff we touched ourself :-) > > If you are not confident with them please drop those DTS from the > patchset > besides the generic one. I can do the rest for you after getting this > set merged. > > Thanks. > - Jiaxun > Hi, Jiaxun Build all dts into vmlinuz will make the vmlinuz bigger and bigger. How does the kernel get the dtb is another big issue, either from built-in dtb or pass from the firmware(pmon and uefi etc). This should be solved with another patch carefully. Providing board specific dts helps to code review, it helps reviewers understand that there are variant boards and have to be express with different OF graph. Now, there are about 6 dts under arch/mips/boot/dts/loongson/, Suppose loongson have 1000+ different board, do you want built all of them into vmlinuz? Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver, pwm driver, clk driver, can you pay more attention to salve those problems, please ?