From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7708C352BE for ; Thu, 16 Apr 2020 14:50:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C63AD21D93 for ; Thu, 16 Apr 2020 14:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="t5PWNeSy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394770AbgDPOuH (ORCPT ); Thu, 16 Apr 2020 10:50:07 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:28534 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394766AbgDPOtL (ORCPT ); Thu, 16 Apr 2020 10:49:11 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587048551; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=Skl7Q5RWa0/wmSos/4aZNHd6qEL+q77C8ZcG2EaOzNY=; b=t5PWNeSy1HiRcwnkPQ8StRRLWCecKOXc5xpoKO4T1btqIycgKAr7gs7fr8EfUGFrQpWlU99L sqjkWItjSwz3VjAszXXlNEjCXyXeR1UWpmh/gGkIsFEQTkXQMQUdyCJMHnsfbDRussg7I56/ Q4ARwqHJG+OSKY9Bb4kHlsE4aBM= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e987055.7ff69210fa08-smtp-out-n02; Thu, 16 Apr 2020 14:48:53 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5BFF7C432C2; Thu, 16 Apr 2020 14:48:52 +0000 (UTC) Received: from [192.168.0.105] (unknown [183.83.68.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vbadigan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 09658C433CB; Thu, 16 Apr 2020 14:48:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 09658C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=vbadigan@codeaurora.org Subject: Re: [PATCH V1 2/4] mmc: sdhci-msm: Enable MMC_CAP_NEED_RSP_BUSY host capability To: Ulf Hansson Cc: Adrian Hunter , Bjorn Andersson , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-arm-msm , Andy Gross References: <1586706808-27337-1-git-send-email-vbadigan@codeaurora.org> <1586706808-27337-3-git-send-email-vbadigan@codeaurora.org> From: Veerabhadrarao Badiganti Message-ID: Date: Thu, 16 Apr 2020 20:18:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On 4/16/2020 5:46 PM, Ulf Hansson wrote: > On Sun, 12 Apr 2020 at 17:54, Veerabhadrarao Badiganti > wrote: >> sdhci-msm controller requires the R1B response for commands that >> has this response associated with them. >> >> So enable MMC_CAP_NEED_RSP_BUSY capability. > I assume this potentially should be considered as fix and tagged for stable? Yes Stable flag can be applied to this. Patch with MMC_CAP_WAIT_WHILE_BUSY cap also needed besides this. Shall I push V2 with stable flag? > Another question, if there is there an upper limit of the busy timeout > in the HW (cmd->busy_timeout) or does the driver use a software > timeout that is adjustable? The max supported h.w busy timeout value on qcom h/w 21sec. > Kind regards > Uffe > >> Signed-off-by: Veerabhadrarao Badiganti >> --- >> drivers/mmc/host/sdhci-msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index 013dcea..d826e9b 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -2088,6 +2088,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) >> } >> >> msm_host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY; >> + msm_host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY; >> >> pm_runtime_get_noresume(&pdev->dev); >> pm_runtime_set_active(&pdev->dev); >> -- >> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project