From: sylv <sylv@sylv.io>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: [PATCH v1 1/1] hwmon: (pmbus) Add regulator supply into macro
Date: Thu, 17 Feb 2022 18:40:47 +0100 [thread overview]
Message-ID: <abfcdd863bb0166a6828c5742bf651eb9409c31b.camel@sylv.io> (raw)
In-Reply-To: <15b95695-6fbc-1916-ff39-abf13e989fc4@roeck-us.net>
On Thu, 2022-02-17 at 09:36 -0800, Guenter Roeck wrote:
> On 2/17/22 02:23, Marcello Sylvester Bauer wrote:
> > Add optional regulator supply into PWBUS_REGULATOR macro. This
> > makes it
>
> The code doesn't look optional to me. What exactly is optional ?
I mean, it is optional to add a supply. It should not cause errors if
you don't. I should probably reword this, too.
>
> > possible to define a vin-supply in DT. Not defining a supply will
> > only
> > cause the following debug output:
> >
> > ```
> > Looking up vin-supply property in node [...] failed
> > ```
> >
> > Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> > ---
> > drivers/hwmon/pmbus/pmbus.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/pmbus/pmbus.h
> > b/drivers/hwmon/pmbus/pmbus.h
> > index e0aa8aa46d8c..38f049d68d32 100644
> > --- a/drivers/hwmon/pmbus/pmbus.h
> > +++ b/drivers/hwmon/pmbus/pmbus.h
> > @@ -464,6 +464,7 @@ extern const struct regulator_ops
> > pmbus_regulator_ops;
> > #define PMBUS_REGULATOR(_name, _id) \
> > [_id] = { \
> > .name = (_name # _id), \
> > + .supply_name = "vin", \
> > .id = (_id), \
> > .of_match = of_match_ptr(_name # _id), \
> > .regulators_node = of_match_ptr("regulators"), \
>
> That seems to be quite far reaching. How does this affect / change
> behavior
> of existing systems which so far did not expect supply_name to be set
> ?
>
> Guenter
next prev parent reply other threads:[~2022-02-17 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 10:23 [PATCH v1 0/1] Add supply into PWBUS_REGULATOR macro Marcello Sylvester Bauer
2022-02-17 10:23 ` [PATCH v1 1/1] hwmon: (pmbus) Add regulator supply into macro Marcello Sylvester Bauer
2022-02-17 17:36 ` Guenter Roeck
2022-02-17 17:40 ` sylv [this message]
2022-02-21 10:59 ` sylv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfcdd863bb0166a6828c5742bf651eb9409c31b.camel@sylv.io \
--to=sylv@sylv.io \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).