From: John Youn <John.Youn@synopsys.com>
To: Nicholas Mc Guire <hofrat@osadl.org>, John Youn <John.Youn@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: simplify list handling
Date: Mon, 7 Nov 2016 11:16:37 -0800 [thread overview]
Message-ID: <ac04e9c7-8300-3f61-b9a6-68f846400827@synopsys.com> (raw)
In-Reply-To: <1478545683-29897-1-git-send-email-hofrat@osadl.org>
On 11/7/2016 11:06 AM, Nicholas Mc Guire wrote:
> The current code is effectively equivalent to list_first_entry_or_null()
> so simply switch and simplify the code.
>
> Fixes: 9c39ddc60ee9 ("USB: s3c-hsotg: Fix stall condition processing")
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> Found by simple coccinelle scanner
>
> Compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m,
> CONFIG_USB_DWC2_PERIPHERAL=y
>
> Patch is against 4.9.0-rc2 (localversion-next is next-20161028)
>
> drivers/usb/dwc2/gadget.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 24fbebc..9ac8ca0 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -1099,10 +1099,8 @@ static int dwc2_hsotg_process_req_status(struct dwc2_hsotg *hsotg,
> */
> static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
> {
> - if (list_empty(&hs_ep->queue))
> - return NULL;
> -
> - return list_first_entry(&hs_ep->queue, struct dwc2_hsotg_req, queue);
> + return list_first_entry_or_null(&hs_ep->queue,
> + struct dwc2_hsotg_req, queue);
> }
>
> /**
>
Hi,
The same is already queued in Felipe's testing/next.
Regards,
John
prev parent reply other threads:[~2016-11-07 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 19:08 [PATCH] usb: dwc2: gadget: simplify list handling Nicholas Mc Guire
2016-11-07 19:16 ` John Youn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac04e9c7-8300-3f61-b9a6-68f846400827@synopsys.com \
--to=john.youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).