From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690A6C433DB for ; Tue, 9 Feb 2021 00:30:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1467564EA1 for ; Tue, 9 Feb 2021 00:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbhBIAaI (ORCPT ); Mon, 8 Feb 2021 19:30:08 -0500 Received: from mga03.intel.com ([134.134.136.65]:10176 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhBIA37 (ORCPT ); Mon, 8 Feb 2021 19:29:59 -0500 IronPort-SDR: PjF1wgAjMJlDUN41qCMQFzdmd46iRYnCQEBHKJmCPum0hIPQ5RNXqxVTkmMBTuwzwf94JbPfBD vpLky/vPEGpg== X-IronPort-AV: E=McAfee;i="6000,8403,9889"; a="181869519" X-IronPort-AV: E=Sophos;i="5.81,163,1610438400"; d="scan'208";a="181869519" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2021 16:28:07 -0800 IronPort-SDR: ddLn2WlVkVbJVHvk7QncLDmv1aI4JRK8JuWV76lf6ZsNz2XwIyMSvMwizs4CNwfw0aibiDXnYe 9W9ZoxJD9XQQ== X-IronPort-AV: E=Sophos;i="5.81,163,1610438400"; d="scan'208";a="395802015" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.27]) ([10.238.4.27]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2021 16:28:03 -0800 Subject: Re: [PATCH 39/49] perf parse-events: Support hybrid raw events To: Arnaldo Carvalho de Melo , kan.liang@linux.intel.com Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@alien8.de, namhyung@kernel.org, jolsa@redhat.com, ak@linux.intel.com, alexander.shishkin@linux.intel.com, adrian.hunter@intel.com, "Jin, Yao" References: <1612797946-18784-1-git-send-email-kan.liang@linux.intel.com> <1612797946-18784-40-git-send-email-kan.liang@linux.intel.com> <20210208190715.GN920417@kernel.org> From: "Jin, Yao" Message-ID: Date: Tue, 9 Feb 2021 08:28:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210208190715.GN920417@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 2/9/2021 3:07 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 08, 2021 at 07:25:36AM -0800, kan.liang@linux.intel.com escreveu: >> From: Jin Yao >> >> On hybrid platform, same raw event is possible to be available on >> both cpu_core pmu and cpu_atom pmu. So it's supported to create >> two raw events for one event encoding. >> >> root@otcpl-adl-s-2:~# ./perf stat -e r3c -a -vv -- sleep 1 >> Control descriptor is not initialized >> ------------------------------------------------------------ > > please move thie command outout two chars to the right > OK, I will make sure the command output two chars to the right in next version. Thanks Jin Yao >> perf_event_attr: >> type 4 >> size 120 >> config 0x3c >> sample_type IDENTIFIER >> read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING >> disabled 1 >> inherit 1 >> exclude_guest 1 >> ------------------------------------------------------------ >> sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 3 >> sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 4 >> sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 5 >> sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 7 >> sys_perf_event_open: pid -1 cpu 4 group_fd -1 flags 0x8 = 8 >> sys_perf_event_open: pid -1 cpu 5 group_fd -1 flags 0x8 = 9 >> sys_perf_event_open: pid -1 cpu 6 group_fd -1 flags 0x8 = 10 >> sys_perf_event_open: pid -1 cpu 7 group_fd -1 flags 0x8 = 11 >> sys_perf_event_open: pid -1 cpu 8 group_fd -1 flags 0x8 = 12 >> sys_perf_event_open: pid -1 cpu 9 group_fd -1 flags 0x8 = 13 >> sys_perf_event_open: pid -1 cpu 10 group_fd -1 flags 0x8 = 14 >> sys_perf_event_open: pid -1 cpu 11 group_fd -1 flags 0x8 = 15 >> sys_perf_event_open: pid -1 cpu 12 group_fd -1 flags 0x8 = 16 >> sys_perf_event_open: pid -1 cpu 13 group_fd -1 flags 0x8 = 17 >> sys_perf_event_open: pid -1 cpu 14 group_fd -1 flags 0x8 = 18 >> sys_perf_event_open: pid -1 cpu 15 group_fd -1 flags 0x8 = 19 >> ------------------------------------------------------------ >> perf_event_attr: >> type 10 >> size 120 >> config 0x3c >> sample_type IDENTIFIER >> read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING >> disabled 1 >> inherit 1 >> exclude_guest 1 >> ------------------------------------------------------------ >> sys_perf_event_open: pid -1 cpu 16 group_fd -1 flags 0x8 = 20 >> sys_perf_event_open: pid -1 cpu 17 group_fd -1 flags 0x8 = 21 >> sys_perf_event_open: pid -1 cpu 18 group_fd -1 flags 0x8 = 22 >> sys_perf_event_open: pid -1 cpu 19 group_fd -1 flags 0x8 = 23 >> sys_perf_event_open: pid -1 cpu 20 group_fd -1 flags 0x8 = 24 >> sys_perf_event_open: pid -1 cpu 21 group_fd -1 flags 0x8 = 25 >> sys_perf_event_open: pid -1 cpu 22 group_fd -1 flags 0x8 = 26 >> sys_perf_event_open: pid -1 cpu 23 group_fd -1 flags 0x8 = 27 >> ... >> >> Performance counter stats for 'system wide': >> >> 13,107,070 r3c >> 316,562 r3c >> >> 1.002161379 seconds time elapsed >> >> It also supports the raw event inside pmu. Syntax is similar: >> >> cpu_core// >> cpu_atom// >> >> root@otcpl-adl-s-2:~# ./perf stat -e cpu_core/r3c/ -vv -- ./triad_loop >> Control descriptor is not initialized >> ------------------------------------------------------------ >> perf_event_attr: >> type 4 >> size 120 >> config 0x3c >> sample_type IDENTIFIER >> read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING >> disabled 1 >> inherit 1 >> enable_on_exec 1 >> exclude_guest 1 >> ------------------------------------------------------------ >> sys_perf_event_open: pid 23641 cpu -1 group_fd -1 flags 0x8 = 3 >> cpu_core/r3c/: 0: 401407363 102724005 102724005 >> cpu_core/r3c/: 401407363 102724005 102724005 >> >> Performance counter stats for './triad_loop': >> >> 401,407,363 cpu_core/r3c/ >> >> 0.103186241 seconds time elapsed >> >> Reviewed-by: Andi Kleen >> Signed-off-by: Jin Yao >> --- >> tools/perf/util/parse-events.c | 56 +++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 55 insertions(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c >> index ddf6f79..6d7a2ce 100644 >> --- a/tools/perf/util/parse-events.c >> +++ b/tools/perf/util/parse-events.c >> @@ -1532,6 +1532,55 @@ static int add_hybrid_numeric(struct parse_events_state *parse_state, >> return 0; >> } >> >> +static int create_hybrid_raw_event(struct parse_events_state *parse_state, >> + struct list_head *list, >> + struct perf_event_attr *attr, >> + struct list_head *head_config, >> + struct list_head *config_terms, >> + struct perf_pmu *pmu) >> +{ >> + struct evsel *evsel; >> + >> + attr->type = pmu->type; >> + evsel = __add_event(list, &parse_state->idx, attr, true, >> + get_config_name(head_config), >> + pmu, config_terms, false, NULL); >> + if (evsel) >> + evsel->pmu_name = strdup(pmu->name); >> + else >> + return -ENOMEM; >> + >> + return 0; >> +} >> + >> +static int add_hybrid_raw(struct parse_events_state *parse_state, >> + struct list_head *list, >> + struct perf_event_attr *attr, >> + struct list_head *head_config, >> + struct list_head *config_terms, >> + bool *hybrid) >> +{ >> + struct perf_pmu *pmu; >> + int ret; >> + >> + *hybrid = false; >> + perf_pmu__for_each_hybrid_pmus(pmu) { >> + *hybrid = true; >> + if (parse_state->pmu_name && >> + strcmp(parse_state->pmu_name, pmu->name)) { >> + continue; >> + } >> + >> + ret = create_hybrid_raw_event(parse_state, list, attr, >> + head_config, config_terms, >> + pmu); >> + if (ret) >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> int parse_events_add_numeric(struct parse_events_state *parse_state, >> struct list_head *list, >> u32 type, u64 config, >> @@ -1558,7 +1607,12 @@ int parse_events_add_numeric(struct parse_events_state *parse_state, >> /* >> * Skip the software dummy event. >> */ >> - if (type != PERF_TYPE_SOFTWARE) { >> + if (type == PERF_TYPE_RAW) { >> + ret = add_hybrid_raw(parse_state, list, &attr, head_config, >> + &config_terms, &hybrid); >> + if (hybrid) >> + return ret; >> + } else if (type != PERF_TYPE_SOFTWARE) { >> if (!perf_pmu__hybrid_exist()) >> perf_pmu__scan(NULL); >> >> -- >> 2.7.4 >> >