From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org, Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swapfile: unuse_pte can map random data if swap read fails
Date: Mon, 4 Apr 2022 15:37:36 +0200 [thread overview]
Message-ID: <ac13a529-5000-19c9-bbd8-3ee634a923cc@redhat.com> (raw)
In-Reply-To: <20220401072926.45051-1-linmiaohe@huawei.com>
On 01.04.22 09:29, Miaohe Lin wrote:
> There is a bug in unuse_pte(): when swap page happens to be unreadable,
> page filled with random data is mapped into user address space. The fix
> is to check for PageUptodate and fail swapoff in case of error.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/swapfile.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 63c61f8b2611..e72a35de7a0f 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1795,6 +1795,10 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd,
> ret = 0;
> goto out;
> }
> + if (unlikely(!PageUptodate(page))) {
> + ret = -EIO;
> + goto out;
> + }
Yeah, we have the same handling in do_swap_page(), whereby we send a
SIGBUS because we're dealing with an actual access.
Interestingly, folio_test_uptodate() states:
"Anonymous and CoW folios are always uptodate."
@Willy, is that true or is the swapin case not documented there?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-04-04 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 7:29 [PATCH] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-04 13:37 ` David Hildenbrand [this message]
2022-04-04 14:11 ` Matthew Wilcox
2022-04-06 8:47 ` Miaohe Lin
2022-04-04 22:53 ` Andrew Morton
2022-04-06 8:44 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac13a529-5000-19c9-bbd8-3ee634a923cc@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).