From: Wadim Egorov <w.egorov@phytec.de>
To: Lee Jones <lee.jones@linaro.org>,
Daniel Schultz <d.schultz@phytec.de>,
linux-rockchip@lists.infradead.org
Cc: zyw@rock-chips.com, zhangqing@rock-chips.com, xsf@rock-chips.com,
tony.xie@rock-chips.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions
Date: Tue, 24 Jul 2018 11:39:51 +0200 [thread overview]
Message-ID: <ac1420fa-7916-813e-a4ef-b7ea403e275b@phytec.de> (raw)
In-Reply-To: <20180416093821.sqrcc6mmnc23njul@dell>
Hi,
Am 16.04.2018 um 11:38 schrieb Lee Jones:
> On Thu, 29 Mar 2018, Daniel Schultz wrote:
>
>> Since all three shutdown functions have almost the same code, all logic
>> from the shutdown functions can be refactored to a new function
>> "rk808_update_bits", which can update a register by a given address and
>> bitmask.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>> Changes:
>> v2: Re-submit with recipients from Rockchip.
>> v3: - Added devicetree property to enable the PMIC reset seperate from
>> "rockchip,system-power-controller".
>> - Dropped the first patch of this serie.
>> v4: Splitted refactoring and the new reset feature.
>> v5: Removed null pointer from rk808_update_bits.
>>
>> drivers/mfd/rk808.c | 46 +++++++++++++---------------------------------
>> 1 file changed, 13 insertions(+), 33 deletions(-)
> I'd still like an Ack/Review from the Rockchip guys please.
>
can someone from Rockchip reply to this?
prev parent reply other threads:[~2018-07-24 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 14:49 [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions Daniel Schultz
2018-03-29 14:50 ` [PATCH v5 2/2] mfd: rk808: Add restart functionality Daniel Schultz
2018-04-16 9:38 ` Lee Jones
2018-04-16 9:38 ` [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions Lee Jones
2018-07-24 9:39 ` Wadim Egorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac1420fa-7916-813e-a4ef-b7ea403e275b@phytec.de \
--to=w.egorov@phytec.de \
--cc=d.schultz@phytec.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tony.xie@rock-chips.com \
--cc=xsf@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).