linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Robin Murphy <robin.murphy@arm.com>
Cc: fenghua.yu@intel.com, jdelvare@suse.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux.dev, janusz.krzysztofik@linux.intel.com,
	lucas.demarchi@intel.com, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] hwmon/coretemp: Simplify platform device antics
Date: Thu, 1 Dec 2022 16:02:03 +0100	[thread overview]
Message-ID: <ac2e553f-fa8b-8b08-aba9-e04529adad34@leemhuis.info> (raw)
In-Reply-To: <20221111213753.GA1059841@roeck-us.net>

Hi, this is your Linux kernel regression tracker. I wondered what
happened to this regression fix, as things looks stalled from here --
but maybe I'm missing something.

On 11.11.22 22:37, Guenter Roeck wrote:
> On Thu, Nov 10, 2022 at 04:20:25PM +0000, Robin Murphy wrote:
>> Coretemp's vestigial platform driver is odd. All the real work is done
>> globally by the initcall and CPU hotplug notifiers, while the "driver"
>> effectively just wraps an allocation and the registration of the hwmon
>> interface in a long-winded round-trip through the driver core. The whole
>> logic of dynamically creating and destroying platform devices to bring
>> the interfaces up and down is fatally flawed right away, since it
>> notifier from a platform bus notifier.
> [...]
>> I haven't been able to fully test hotplug since I only have a
>> single-socket Intel system to hand.
> Someone with access to hardware will have to validate this.

That afaics has happened.

> For both subject and description, please avoid terms like "antics",
> "odd", or "questionable". Please describe the problem in neutral terms.

Robin, did you take care of that?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

#regzbot ignore-activity

  reply	other threads:[~2022-12-01 15:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 16:20 [PATCH] hwmon/coretemp: Simplify platform device antics Robin Murphy
2022-11-10 16:45 ` Janusz Krzysztofik
2022-11-14  8:46   ` Janusz Krzysztofik
2022-11-11 21:37 ` Guenter Roeck
2022-12-01 15:02   ` Thorsten Leemhuis [this message]
2022-12-06  5:54     ` Thorsten Leemhuis
2022-11-15 10:14 ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac2e553f-fa8b-8b08-aba9-e04529adad34@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=fenghua.yu@intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lucas.demarchi@intel.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).